Skip to content

fix(workflows): fix sync-status, idempotency, and artifact versions#73

Closed
MarkusNeusinger wants to merge 1 commit intomainfrom
fix/workflow-issues-test
Closed

fix(workflows): fix sync-status, idempotency, and artifact versions#73
MarkusNeusinger wants to merge 1 commit intomainfrom
fix/workflow-issues-test

Conversation

@MarkusNeusinger
Copy link
Copy Markdown
Owner

Summary

  • Fix bot-sync-status PR body parsing that caused shell errors
  • Add idempotency check to prevent duplicate 'Generation Complete' comments
  • Standardize artifact action versions to v4 for compatibility

Changes

File Fix
bot-sync-status.yml Safely fetch PR body via gh pr view instead of direct variable
gen-new-plot.yml Check if summary comment exists before posting
bot-ai-review.yml download-artifact v6 → v4
ci-plottest.yml upload-artifact v5 → v4
ci-unittest.yml upload-artifact v5 → v4
gen-preview.yml download/upload v5/v6 → v4

Test plan

  • Merge to main
  • Create new simple plot request
  • Verify no duplicate comments
  • Verify status table updates correctly

- bot-sync-status: safely fetch PR body via gh CLI to avoid shell escaping
- gen-new-plot: add idempotency check to prevent duplicate 'Generation Complete' comments
- Standardize all artifact actions to v4 for compatibility:
  - bot-ai-review: download-artifact v6 → v4
  - ci-plottest: upload-artifact v5 → v4
  - ci-unittest: upload-artifact v5 → v4
  - gen-preview: download/upload v5/v6 → v4
Copilot AI review requested due to automatic review settings December 1, 2025 15:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes three issues in GitHub Actions workflows: shell escaping errors in PR body parsing, duplicate comment posting, and artifact action version compatibility. The changes align artifact actions to v4 across all workflows, add an idempotency check to prevent duplicate completion comments, and use the GitHub CLI to safely fetch PR bodies.

Key Changes:

  • Add idempotency check in gen-new-plot.yml to prevent duplicate "Generation Complete" comments
  • Fix shell escaping issues in bot-sync-status.yml by using gh pr view instead of direct variable expansion
  • Standardize artifact actions to v4 across all workflows

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/gen-new-plot.yml Adds idempotency check before posting summary comment and removes unused results collection code
.github/workflows/bot-sync-status.yml Replaces direct PR body variable expansion with gh pr view to avoid shell escaping errors
.github/workflows/bot-ai-review.yml Downgrades download-artifact from v6 to v4 for cross-workflow artifact downloads
.github/workflows/gen-preview.yml Downgrades both download-artifact and upload-artifact to v4
.github/workflows/ci-plottest.yml Downgrades upload-artifact from v5 to v4
.github/workflows/ci-unittest.yml Downgrades upload-artifact from v5 to v4
Comments suppressed due to low confidence (2)

.github/workflows/bot-ai-review.yml:45

  • The run-id parameter for cross-workflow artifact downloads requires actions/download-artifact@v4.1.0 or later. When using @v4, GitHub Actions typically resolves to the latest v4.x version, but if this repository has version pinning or if v4 resolves to an earlier version, this will fail. Consider using actions/download-artifact@v4.1.8 or later explicitly to ensure the run-id parameter is supported, or verify that @v4 resolves to v4.1.0+.
        uses: actions/download-artifact@v4
        with:
          name: plot-metadata
          run-id: ${{ github.event.workflow_run.id }}
          github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/gen-preview.yml:42

  • The run-id parameter for cross-workflow artifact downloads requires actions/download-artifact@v4.1.0 or later. When using @v4, GitHub Actions typically resolves to the latest v4.x version, but if this repository has version pinning or if v4 resolves to an earlier version, this will fail. Consider using actions/download-artifact@v4.1.8 or later explicitly to ensure the run-id parameter is supported.
        uses: actions/download-artifact@v4
        with:
          pattern: test-results-*
          path: all-test-results
          merge-multiple: true
          run-id: ${{ github.event.workflow_run.id }}
          github-token: ${{ secrets.GITHUB_TOKEN }}

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@MarkusNeusinger
Copy link
Copy Markdown
Owner Author

Closing: Contains incorrect artifact version downgrades. Will create new PR with only the correct fixes.

@MarkusNeusinger MarkusNeusinger deleted the fix/workflow-issues-test branch December 1, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants