Resonance Test : for Fixed Time motion system and/or standard motion system#28282
Resonance Test : for Fixed Time motion system and/or standard motion system#28282narno2202 wants to merge 72 commits into
Conversation
…ges to ResonanceGenerator class, move resonance menu outside FT_MOTION conditional in menu_motion.cpp
Refactor fast_sin to calc_next_pos for improved sine calculation and phase handling.
df3a7cb to
29bee75
Compare
|
@dbuezas, I have a fixed point arithmetic version (my first experience with it). I struggled with motion drift both with FT_MOTION and the standard motion system (cumulative errors), but now it seems ok. Could you have a look please. Just replace the 2 files in the feature/resonance folder with these in the zip file. |
|
sure, can you send me a link to a commit with those changes so i can see on my phone and comment? |
|
For now, I just have a local development environment. All is based upon this PR; only resonance_generator.cPp and .h are different the files in the zip). |
|
Please make a branch, commit those changes and send me a link to it |
1bc0732 to
72c7874
Compare
|
Getting this merged and then will merge into yesterday's PR for 2208…. |
3ae3ee7 to
9137691
Compare
9137691 to
4363ec1
Compare
|
Is this ready for merge? Current exiter code is broken as noted in #28383 |
|
It's fixed point arithmetic for standard motion and FT_MOTION. There is no longer a relationship to FTM_TS in FT_MOTION. Testing and feedback are welcome. |
Description
After refactoring ResonanceGenerator class and files location, I add the resonance test to standard motion. The resonance test could run either in FT_MOTION or in standard motion system. ResoanceGenerator has been improved to deal with MCU without FPU.
FTM_RESONANCE_TESTis renamedRESONANCE_TESTwhich is defined inConfiguration_adv.h.resonance_generator.h and .cppare moved to thesrc/feature/resonance/folder, andM495_M496.cppto thegcode/feature/resonancefolder. M495 and M496 are no more linked only toFT_MOTION.features.iniis modified accordingly and #include directives have been updated.rtgis defined asextern ResonanceGenerator rtginresonance_generator.h.resonance.cppandresonance.hThe speed is constant for standard motion and is 100mm/s (8000 steps/s with "standard" 80 steps/mm) for X and Y axis and 2000 steps/s for Z axis. The time constant is 0.001s (same value as in basic
FT_MOTIONconfiguration). Please test and report.Requirements
RESONANCE_TEST enabled
Benefits
Improve ResonanceGenerator class, resonance test available for FT_MOTION and standard motion system
Configurations
Related Issues
None