Fix Resonance Testing with TMC2208#28386
Merged
thinkyhead merged 3 commits intoMay 6, 2026
Merged
Conversation
|
Is there a way to do this while avoiding code duplication between resonance test and normal FTM code path? |
Contributor
Author
|
Yes, it's in PR #28282 (resonance refactoring for standard and FT_MOTION). I can also make the same changes regarding TMC2208 in this PR, but I prefer the refactored version. |
Member
|
I wonder how it would work to run the FT Motion tuner web application by @dbuezas inside of a VSCode WebView…? We can also distribute other companion apps in the form of Python with some preferred UI like Tk or Gradio or whatever other local Web UI the kids prefer these days, in addition to inclusion on the new web site. |
thinkyhead
changed the title
Contributor
Author
|
Something like that ? (launch from github live app) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As reported by @Huang-wjj, FT_MOTION resonance test fails with TMC2208 because
HAS_FTM_DIR_CHANGE_HOLDis not used. This PR adds the relevant code.Requirements
Benefits
Configurations
Related Issues
Fix #28383