Test get_item_unchecked

Author: MarshalX

src/lib.rs

@@ -103,38 +103,40 @@ fn map_key_cmp(a: &[u8], b: &[u8]) -> std::cmp::Ordering {
 
 fn sort_map_keys(keys: &Bound<PyList>, len: usize) -> Result<Vec<(PyBackedStr, usize)>> {
     // Returns key and index.
-    let mut keys_str = Vec::with_capacity(len);
-    for i in 0..len {
-        let item = keys.get_item(i)?;
-        let key = match item.cast::<PyString>() {
-            Ok(k) => k.to_owned(),
-            Err(_) => return Err(anyhow!("Map keys must be strings")),
-        };
-        let backed_str = match PyBackedStr::try_from(key) {
-            Ok(bs) => bs,
-            Err(_) => return Err(anyhow!("Failed to convert PyString to PyBackedStr")),
-        };
-        keys_str.push((backed_str, i));
-    }
+    unsafe {
+        let mut keys_str = Vec::with_capacity(len);
+        for i in 0..len {
+            let item = keys.get_item_unchecked(i);
+            let key = match item.cast::<PyString>() {
+                Ok(k) => k.to_owned(),
+                Err(_) => return Err(anyhow!("Map keys must be strings")),
+            };
+            let backed_str = match PyBackedStr::try_from(key) {
+                Ok(bs) => bs,
+                Err(_) => return Err(anyhow!("Failed to convert PyString to PyBackedStr")),
+            };
+            keys_str.push((backed_str, i));
+        }
 
-    if keys_str.len() < 2 {
-        return Ok(keys_str);
-    }
+        if keys_str.len() < 2 {
+            return Ok(keys_str);
+        }
 
-    keys_str.sort_by(|a, b| {
-        // sort_unstable_by performs bad
-        let (s1, _) = a;
-        let (s2, _) = b;
+        keys_str.sort_by(|a, b| {
+            // sort_unstable_by performs bad
+            let (s1, _) = a;
+            let (s2, _) = b;
 
-        // sorted length-first by the byte representation of the string keys
-        if s1.len() != s2.len() {
-            s1.len().cmp(&s2.len())
-        } else {
-            s1.cmp(s2)
-        }
-    });
+            // sorted length-first by the byte representation of the string keys
+            if s1.len() != s2.len() {
+                s1.len().cmp(&s2.len())
+            } else {
+                s1.cmp(s2)
+            }
+        });
 
-    Ok(keys_str)
+        Ok(keys_str)
+    }
 }
 
 fn get_bytes_from_py_any<'py>(obj: &'py Bound<'py, PyAny>) -> PyResult<&'py [u8]> {
@@ -354,7 +356,9 @@ where
         types::Array::bounded(len, w)?;
 
         for i in 0..len {
-            encode_dag_cbor_from_pyobject(_py, &l.get_item(i)?, w)?;
+            unsafe {
+                encode_dag_cbor_from_pyobject(_py, &l.get_item_unchecked(i), w)?;
+            }
         }
 
         Ok(())
@@ -369,7 +373,9 @@ where
             key.get(..)
                 .expect("whole range is a valid string")
                 .encode(w)?;
-            encode_dag_cbor_from_pyobject(_py, &values.get_item(i)?, w)?;
+            unsafe {
+                encode_dag_cbor_from_pyobject(_py, &values.get_item_unchecked(i), w)?;
+            }
         }
 
         Ok(())