refactor(list): extract DateHierarchyBar from ListPage into @dar/list (#428)#501
Merged
Merged
Conversation
…#428) First incremental step of decomposing the ListPage god-component: lift the self-contained date_hierarchy drill-down bar (+ its MONTH_NAMES) into @dar/list as a props-driven, individually-testable component, and add the package's first vitest. No behaviour change — ListPage now composes it. ListPage.tsx drops 837 → 729 lines. @dar/list gains react as a peer/dev dep (mirroring @dar/search) and is wired into apps/web. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Architect review + merge (multi-role, authorised on this repo). Verified locally in a clean worktree off
The extraction is verbatim (component logic + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First incremental step of #428 (decompose the ListPage / DetailPage god-components). Starting with ListPage since it's the larger one and — unlike DetailPage — isn't touched by the in-flight #427/#465 drafts, so no collision.
Role: Author / Architect.
Change
Lift the self-contained
date_hierarchydrill-down bar (and itsMONTH_NAMES) out ofListPage.tsxinto a props-driven, individually-testable component in@dar/list— the package #303 wants the list page to live in.ListPagenow composes<DateHierarchyBar dh=… onNavigate=… />.ListPage.tsx: 837 → 729 lines (−108).@dar/listgainsreactas a peer/dev dep (mirroring@dar/search) and is wired intoapps/web.This establishes the extraction+test pattern; follow-up PRs lift the filter/columns modals, pagination, and the
list_editablecontroller (each its own small PR, per the issue).Verification
pnpm -r typecheckclean (13/13),pnpm lintclean (incl. eslint import-boundary on@dar/list+ dark-mode guard),pnpm test97 passed (16 files; +3 new).🤖 Generated with Claude Code