fix(spa): move Customize onto the filter row, after Clear all (#554)#558
Merged
Conversation
Closes #554. The header right-side now carries only the +Add primary action; Customize moves into the FilterBar's `trailing` slot so the filter row reads as one self-contained unit: … filter chips | Clear all | Customize `Clear all` continues to hide when no filter is active (already wired that way). `Customize` is always visible — it's a column-affordance, independent of filter state. Both buttons use the same row-aligned `py-1.5` size so the chrome lines up cleanly. No second toolbar row, no dangling chrome — matches the "no redundant chrome" rule. - typecheck + eslint + stylelint + **dark-mode guard** clean. - vitest: 142 passed (unchanged). - `pnpm -r build` ok. Closes #554 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #554.
Header right-side now carries only
+ Add;Customizemoves into the FilterBar'strailingslot so the filter row reads as a single self-contained unit:Clear allhides when no filter is active (already wired that way).Customizeis always visible — it's a column-affordance independent of filter state.py-1.5size so the chrome lines up cleanly.Verification
pnpm -r typecheckclean (13 pkgs).pnpm lintclean (eslint --max-warnings 0 + stylelint + dark-mode guard).pnpm test→ 142 passed (unchanged).pnpm -r buildok.Tier 4 (frontend only).
🤖 Generated with Claude Code