fix(spa): detail toolbar buttons inline, drop ml-auto cluster (#677) + 1.11.2#678
Merged
Merged
Conversation
…+ 1.11.2 History / Refresh / Edit / Delete were grouped in a right-aligned `ml-auto` cluster (#658/#672), which read as a second toolbar in its own column and could float disconnected from its row on narrow viewports. They are now plain buttons in the single `flex-wrap` toolbar, flowing inline with the custom `@admin.action` buttons and wrapping naturally — DOM order `[History] [...custom actions] [Refresh] [Edit] [Delete]`, no spacer. Destructive emphasis on Delete stays the button's own variant, not position. Flips the two regression tests that pinned the `ml-auto` cluster to assert the no-ml-auto inline contract (DOM order preserved). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #677.
Summary
The detail-page toolbar grouped History / Refresh / Edit / Delete in a right-aligned
ml-autocluster (added in #658, reinforced in #672). On a wrapped toolbar that reads as a second toolbar in its own column, and on narrow viewports the cluster floats disconnected from the row it logically follows.Per #677, the built-ins are now plain buttons in the single
flex-wraptoolbar, flowing inline with the custom@admin.actionbuttons and wrapping naturally wherever they fall.Change
<div className="ml-auto …">wrapper around Refresh/Edit/Delete; they're now direct children of the one toolbar flex container.[History] [...custom batch actions] [...custom detail actions] [Refresh] [Edit] [Delete]— render order == DOM order, no skipping.ml-auto/ spacer / second-column treatment anywhere in the toolbar. Destructive emphasis on Delete stays the button's ownvariant, not its position.Acceptance criteria (from #677)
flex-wrapcontainer; noml-auto(or equivalent) right-aligning a subset.[History] [...custom] [Refresh] [Edit] [Delete], render order == DOM order.Tests
Flipped the two regression guards that previously pinned the
ml-autocluster (#658/#672) to assert the no-ml-autoinline contract + preserved DOM order. DetailPage suite 6 passed; eslint (max-warnings 0), dark-mode coverage, web typecheck all green. Patch release 1.11.2.🤖 Generated with Claude Code