Skip to content

Commit 43a5148

Browse files
committed
set show_cone to false by default for faster updating graphs, plus fix doc error
1 parent 6330ed4 commit 43a5148

3 files changed

Lines changed: 8 additions & 3 deletions

File tree

PyMieSim/cpp/single/detector/interface.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1038,7 +1038,8 @@ PYBIND11_MODULE(detector, module) {
10381038
const py::object& ax,
10391039
const double field_point_size,
10401040
const double point_radial_offset,
1041-
const bool show_axes
1041+
const bool show_axes,
1042+
const bool show_cone
10421043
) -> void {
10431044
ensure_matplotlib_3d_axis(ax);
10441045

@@ -1056,6 +1057,7 @@ PYBIND11_MODULE(detector, module) {
10561057
py::arg("field_point_size") = 20.0,
10571058
py::arg("point_radial_offset") = 1.025,
10581059
py::arg("show_axes") = false,
1060+
py::arg("show_cone") = false,
10591061
R"pbdoc(
10601062
Add the integrating sphere angular mesh to a Matplotlib 3D axis.
10611063
@@ -1077,6 +1079,9 @@ PYBIND11_MODULE(detector, module) {
10771079
If ``True``, display Cartesian axis labels, ticks, and panes.
10781080
If ``False``, hide the Matplotlib 3D axis frame after setting
10791081
the plotting limits.
1082+
show_cone : bool, optional
1083+
Ignored for this detector type since the integrating sphere
1084+
represents full angular collection.
10801085
10811086
Notes
10821087
-----

PyMieSim/cpp/single/setup/interface.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,7 @@ PYBIND11_MODULE(setup, module)
860860
},
861861
py::arg("show_axes") = false,
862862
py::arg("show_colorbar") = true,
863-
py::arg("show_detector_cone") = true,
863+
py::arg("show_detector_cone") = false,
864864
py::arg("show_unit_sphere") = true,
865865
py::arg("figure_size") = 7.0,
866866
R"pbdoc(

docs/examples/single/farfields.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@
4343
figure = far_fields.plot("phi_imag")
4444

4545
## Visualize the far-fields: phi_magnitude component
46-
figure = far_fields.plot("phi_magnitude")
46+
figure = far_fields.plot("phi_intensity")

0 commit comments

Comments
 (0)