Persist Z home (G92) and Zm across restarts; fix NVS handle leaks; add Z home safety check by Copilot · Pull Request #937 · MaslowCNC/Maslow_4

Copilot · 2026-04-24T19:43:43Z

Persist Z home (G92) and Zm to NVS on state→Idle transitions
Fix NVS handle leaks in saveZPos/loadZPos
Add zm/zhome fields to MINFO JSON
Add zm/zhome to maslowStatus in Web UI
Merge latest Maslow-Main changes (first merge)
Show confirmation popup "Z home outside safe bounds" when Zm + Z home < 0 on Set Z-Stop
Merge latest Maslow-Main changes (second merge — PR Sanitize invalid persisted startup Z using Zm + Z home bounds, with non-reset warning for high Zm #967, PR FluidNC Config Items: show active Config/Filename instead of hardcoded maslow.yaml #971)

Agent-Logs-Url: https://github.com/MaslowCNC/Maslow_4/sessions/53d79658-a775-44f1-bf60-12b0ef3a9152 Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

IDAbbott · 2026-04-24T20:12:35Z

@MaslowBot please build

github-actions · 2026-04-24T20:15:20Z

🤖 Firmware & Web UI Compilation Complete 🤖

✅ Successfully compiled FluidNC firmware and ESP3D-WEBUI

Firmware Build Details:

Commit: a471075b2f43f43b181f5a347aa4322c1e297765
Version: v1.20-64-ga471075b-dirty
Environment: wifi_s3 (ESP32-S3)
Firmware size: 1.89 MB
Flash usage: 1.89 MB (64.2%)
RAM usage: 136.1 KB (42.5%)

Web UI Build Details:

Language: English only
WebUI size: 135.66 KB (compressed)
Format: index.html.gz

Download:
The firmware package (containing firmware.bin, index.html.gz, and installation instructions) has been uploaded as a build artifact named "firmware-package" and can be downloaded from the Actions tab.

To test this release please:
[] Try running calibration with a fresh maslow.yaml file
[] Test jogging the machine to see that movements are normal
[] Try running a simple gcode file

This comment was automatically generated in response to a build request comment.

IDAbbott · 2026-04-25T07:11:26Z

@MaslowBot Whenever Z changes save new values for z home and Zm to NVS

MaslowBot · 2026-04-25T07:11:35Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@MaslowBot Whenever Z changes save new values for V home and Vm to NVS

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request.

IDAbbott · 2026-04-25T07:13:16Z

@MaslowBot for previous request change V home and Vm to Z home and Zm

MaslowBot · 2026-04-25T07:13:25Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@MaslowBot for previous request change V home and Vm to Z home and Zm

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request.

Agent-Logs-Url: https://github.com/MaslowCNC/Maslow_4/sessions/4be078a7-95d5-4def-bef9-2829b4022c5d Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot · 2026-04-25T07:16:31Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:...

Done in ab384aa. The save trigger in Maslow_::update() was broadened from (Jog || Cycle) → Idle to any state → Idle. This means Z home ("zG92") and Zm ("zPos") are now written to NVS whenever the machine returns to Idle after any operation — Jog, Cycle, Hold, or Homing. The saveZPos() function already skips the NVS write when the values haven't changed, so flash wear is not increased.

Copilot · 2026-04-25T07:17:44Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:...

The implementation already targets Z home and Zm — the previous commit (ab384aa) saves "zG92" (Z home offset) and "zPos" (machine Z) to NVS on every state→Idle transition. No changes needed.

IDAbbott · 2026-04-25T07:23:53Z

@MaslowBot please build

github-actions · 2026-04-25T07:26:20Z

🤖 Firmware & Web UI Compilation Complete 🤖

✅ Successfully compiled FluidNC firmware and ESP3D-WEBUI

Firmware Build Details:

Commit: ab384aa967c3fc90c5aa704fe2b57c25ebeea386
Version: v1.20-65-gab384aa9-dirty
Environment: wifi_s3 (ESP32-S3)
Firmware size: 1.89 MB
Flash usage: 1.89 MB (64.2%)
RAM usage: 136.1 KB (42.5%)

Web UI Build Details:

Language: English only
WebUI size: 135.66 KB (compressed)
Format: index.html.gz

Download:
The firmware package (containing firmware.bin, index.html.gz, and installation instructions) has been uploaded as a build artifact named "firmware-package" and can be downloaded from the Actions tab.

To test this release please:
[] Try running calibration with a fresh maslow.yaml file
[] Test jogging the machine to see that movements are normal
[] Try running a simple gcode file

This comment was automatically generated in response to a build request comment.

davidelang · 2026-04-26T11:24:02Z

IDAbbott wrote:

@MaslowBot Whenever Z changes save new values for V home and Vm to NVS

NVS has a limited number of writes. This is why we only save values when we go idle (i.e. not likely to change again soon) David Lang

MaslowBot · 2026-04-26T11:24:10Z

@copilot-swe-agent

User @davidelang mentioned @MaslowBot with the following request:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

IDAbbott wrote:

@MaslowBot Whenever Z changes save new values for V home and Vm to NVS

NVS has a limited number of writes. This is why we only save values when we go
idle (i.e. not likely to change again soon)

David Lang

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request.

Copilot · 2026-04-26T11:24:53Z

@copilot-swe-agent

User @davidelang mentioned @MaslowBot with the following request:...

Agreed — the current implementation already follows the save-on-idle pattern. saveZPos() is only called from two places: (1) in update() on any state→Idle transition (not on every Z movement), and (2) once in setZStop() when the user explicitly sets Z home (a single deliberate user action). A change-detection guard in saveZPos() additionally skips the NVS write entirely when the values haven't changed, so flash wear is minimised.

IDAbbott · 2026-05-15T21:00:22Z

@MaslowBot please update from maslow-main branch

MaslowBot · 2026-05-15T21:00:31Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@MaslowBot please update from maslow-main branch

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request.

…home-and-zm-values-are-stored # Conflicts: # ESP3D-WEBUI/www/js/maslow.js Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot · 2026-05-15T21:02:36Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:...

Done in 14c01b0. Merged origin/Maslow-Main — one conflict in maslow.js resolved by keeping both our zm/zhome fields and the new APPLY_TENSION_WARNING_PREFIX constant from Maslow-Main.

IDAbbott · 2026-05-15T21:03:35Z

@MaslowBot please build

github-actions · 2026-05-15T21:06:20Z

🤖 Firmware & Web UI Compilation Complete 🤖

✅ Successfully compiled FluidNC firmware and ESP3D-WEBUI

Firmware Build Details:

Commit: 14c01b0187f4234ef546a366639b3a29380293e3
Version: v1.21-61-g14c01b01-dirty
Environment: wifi_s3 (ESP32-S3)
Firmware size: 1.90 MB
Flash usage: 1.90 MB (64.6%)
RAM usage: 136.1 KB (42.5%)

Web UI Build Details:

Language: English only
WebUI size: 140.71 KB (compressed)
Format: index.html.gz

Download:
The firmware package (containing firmware.bin, index.html.gz, and installation instructions) has been uploaded as a build artifact named "firmware-package" and can be downloaded from the Actions tab.

To test this release please:
[] Try running calibration with a fresh maslow.yaml file
[] Test jogging the machine to see that movements are normal
[] Try running a simple gcode file

This comment was automatically generated in response to a build request comment.

IDAbbott · 2026-05-15T21:38:12Z

@MaslowBot If Zm + Z home is less than 0 then show confirmation popup Z home outside safe bounds

MaslowBot · 2026-05-15T21:38:20Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@MaslowBot If Zm + Z home is less than 0 then show confirmation popup Z home outside safe bounds

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request.

Agent-Logs-Url: https://github.com/MaslowCNC/Maslow_4/sessions/dddde237-a256-4f41-9506-d083f53713ab Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot · 2026-05-15T21:41:17Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:...

Done in 1096ed4. In tabletCalSetZStop, before sending $SETZSTOP, the code now checks whether maslowStatus.zm + maslowStatus.zhome < 0 (both values must be populated from $MINFO — if either is missing the check is skipped and the command proceeds normally). When the condition is true a confirmdlg popup appears with:

Title: "Z Home Outside Safe Bounds"
Message: "The Z home position is outside the safe operating range. Setting Z home here may cause the Z-axis to move below safe limits. Proceed anyway?"

The $SETZSTOP command is only sent if the user clicks Yes.

IDAbbott · 2026-05-15T21:42:38Z

@MaslowBot please build

github-actions · 2026-05-15T21:44:58Z

🤖 Firmware & Web UI Compilation Complete 🤖

✅ Successfully compiled FluidNC firmware and ESP3D-WEBUI

Firmware Build Details:

Commit: 1096ed4e8b4e1624bd87b571cab55a3e93324930
Version: v1.21-62-g1096ed4e-dirty
Environment: wifi_s3 (ESP32-S3)
Firmware size: 1.90 MB
Flash usage: 1.90 MB (64.6%)
RAM usage: 136.1 KB (42.5%)

Web UI Build Details:

Language: English only
WebUI size: 140.84 KB (compressed)
Format: index.html.gz

Download:
The firmware package (containing firmware.bin, index.html.gz, and installation instructions) has been uploaded as a build artifact named "firmware-package" and can be downloaded from the Actions tab.

To test this release please:
[] Try running calibration with a fresh maslow.yaml file
[] Test jogging the machine to see that movements are normal
[] Try running a simple gcode file

This comment was automatically generated in response to a build request comment.

IDAbbott · 2026-05-17T19:50:38Z

@MaslowBot please update from maslow-main branch

MaslowBot · 2026-05-17T19:50:46Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@MaslowBot please update from maslow-main branch

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request.

…home-and-zm-values-are-stored Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot · 2026-05-17T19:52:11Z

@copilot-swe-agent

User @IDAbbott mentioned @MaslowBot with the following request:...

Done in 328235d. Merged origin/Maslow-Main (PRs #967 and #971) — clean merge, no conflicts. The new warning-handler functions from Maslow-Main (showZHomeResetWarningMessage, showZmInvalidWarningMessage) are now in alongside our zm/zhome additions.

IDAbbott · 2026-05-17T19:58:31Z

@MaslowBot please build

github-actions · 2026-05-17T20:00:57Z

🤖 Firmware & Web UI Compilation Complete 🤖

✅ Successfully compiled FluidNC firmware and ESP3D-WEBUI

Firmware Build Details:

Commit: 328235d0e4d6ec9c5229eed334eb0b6b382288cc
Version: v1.21-79-g328235d0-dirty
Environment: wifi_s3 (ESP32-S3)
Firmware size: 1.90 MB
Flash usage: 1.90 MB (64.7%)
RAM usage: 136.1 KB (42.5%)

Web UI Build Details:

Language: English only
WebUI size: 141.05 KB (compressed)
Format: index.html.gz

Download:
The firmware package (containing firmware.bin, index.html.gz, and installation instructions) has been uploaded as a build artifact named "firmware-package" and can be downloaded from the Actions tab.

To test this release please:
[] Try running calibration with a fresh maslow.yaml file
[] Test jogging the machine to see that movements are normal
[] Try running a simple gcode file

This comment was automatically generated in response to a build request comment.

Initial plan

7e722f9

Copilot AI assigned Copilot and MaslowBot Apr 24, 2026

Copilot started work on behalf of MaslowBot April 24, 2026 19:43 View session

Copilot AI linked an issue Apr 24, 2026 that may be closed by this pull request

How are Z home and Zm values stored across restarts #936

Open

Fix Z home (G92) and Zm persistence across restarts

a471075

Agent-Logs-Url: https://github.com/MaslowCNC/Maslow_4/sessions/53d79658-a775-44f1-bf60-12b0ef3a9152 Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Show code for storing Z home and Z machine values~~ Persist Z home (G92) and Zm across restarts; fix NVS handle leaks Apr 24, 2026

Copilot finished work on behalf of MaslowBot April 24, 2026 20:03

Copilot AI requested a review from MaslowBot April 24, 2026 20:03

Copilot started work on behalf of MaslowBot April 25, 2026 07:11 View session

Save Z home and Zm to NVS on any state transition to Idle

ab384aa

Agent-Logs-Url: https://github.com/MaslowCNC/Maslow_4/sessions/4be078a7-95d5-4def-bef9-2829b4022c5d Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot finished work on behalf of MaslowBot April 25, 2026 07:17

Copilot started work on behalf of MaslowBot April 25, 2026 07:17 View session

Copilot finished work on behalf of MaslowBot April 25, 2026 07:18

Copilot started work on behalf of MaslowBot April 26, 2026 11:24 View session

Copilot finished work on behalf of MaslowBot April 26, 2026 11:25

Copilot started work on behalf of MaslowBot May 15, 2026 21:00 View session

Merge remote-tracking branch 'origin/Maslow-Main' into copilot/how-z-…

14c01b0

…home-and-zm-values-are-stored # Conflicts: # ESP3D-WEBUI/www/js/maslow.js Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot finished work on behalf of MaslowBot May 15, 2026 21:03

Copilot started work on behalf of MaslowBot May 15, 2026 21:38 View session

Show confirmation popup when Z home outside safe bounds (Zm + Zhome < 0)

1096ed4

Agent-Logs-Url: https://github.com/MaslowCNC/Maslow_4/sessions/dddde237-a256-4f41-9506-d083f53713ab Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot AI changed the title ~~Persist Z home (G92) and Zm across restarts; fix NVS handle leaks~~ Persist Z home (G92) and Zm across restarts; fix NVS handle leaks; add Z home safety check May 15, 2026

Copilot finished work on behalf of MaslowBot May 15, 2026 21:42

Copilot started work on behalf of MaslowBot May 17, 2026 19:50 View session

Merge remote-tracking branch 'origin/Maslow-Main' into copilot/how-z-…

328235d

…home-and-zm-values-are-stored Co-authored-by: MaslowBot <231786780+MaslowBot@users.noreply.github.com>

Copilot finished work on behalf of MaslowBot May 17, 2026 19:52

Conversation

Copilot AI commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IDAbbott commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

IDAbbott commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MaslowBot commented Apr 25, 2026

Uh oh!

IDAbbott commented Apr 25, 2026

Uh oh!

MaslowBot commented Apr 25, 2026

Uh oh!

Copilot AI commented Apr 25, 2026

Uh oh!

Copilot AI commented Apr 25, 2026

Uh oh!

IDAbbott commented Apr 25, 2026

Uh oh!

github-actions Bot commented Apr 25, 2026

Uh oh!

davidelang commented Apr 26, 2026 via email

Uh oh!

MaslowBot commented Apr 26, 2026

Uh oh!

Copilot AI commented Apr 26, 2026

Uh oh!

IDAbbott commented May 15, 2026

Uh oh!

MaslowBot commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

IDAbbott commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

IDAbbott commented May 15, 2026

Uh oh!

MaslowBot commented May 15, 2026

Uh oh!

Copilot AI commented May 15, 2026

Uh oh!

IDAbbott commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

IDAbbott commented May 17, 2026

Uh oh!

MaslowBot commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

IDAbbott commented May 17, 2026

Uh oh!

github-actions Bot commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 24, 2026 •

edited

Loading

IDAbbott commented Apr 25, 2026 •

edited

Loading