fix: relative endpoint URL resolution when saving to SPARQL workspace (#118)

* Initial plan

* Add resolveEndpointUrl utility and update Tab.ts to resolve relative endpoints

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

* Address code review feedback: use startsWith() and remove edge case test

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

* Improve variable naming: rename basePath to currentDirectory for clarity

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

* fix: quick describe didn't always work for prefixed URIs (#120)

* Initial plan

* Fix quick describe for tokenized prefixed URIs

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

* Address code review feedback - use template literals and improved parsing

Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MathiasVDA <15101339+MathiasVDA@users.noreply.github.com>

Author: Copilot

packages/yasgui/src/Tab.ts

@@ -17,6 +17,7 @@ import { saveManagedQuery } from "./queryManagement/saveManagedQuery";
 import { getWorkspaceBackend } from "./queryManagement/backends/getWorkspaceBackend";
 import { asWorkspaceBackendError } from "./queryManagement/backends/errors";
 import { normalizeQueryFilename } from "./queryManagement/normalizeQueryFilename";
+import { resolveEndpointUrl } from "./urlUtils";
 
 export interface PersistedJsonYasr extends YasrPersistentConfig {
   responseSummary: Parser.ResponseSummary;
@@ -304,7 +305,7 @@ export class Tab extends EventEmitter {
         name: result.name,
         filename: result.filename,
         queryText: this.getQueryTextForSave(),
-        associatedEndpoint: workspace.type === "sparql" ? this.getEndpoint() : undefined,
+        associatedEndpoint: workspace.type === "sparql" ? resolveEndpointUrl(this.getEndpoint()) : undefined,
         message: result.message,
         expectedVersionTag,
       });

packages/yasgui/src/urlUtils.ts

@@ -0,0 +1,40 @@
+/**
+ * Converts a relative or absolute URL to a fully qualified URL with protocol and host.
+ * Uses the current page's protocol and host for relative URLs.
+ *
+ * @param url - The URL to resolve (can be relative like "/sparql", or absolute like "http://example.com/sparql")
+ * @returns The fully qualified URL with protocol and host
+ *
+ * @example
+ * // On page https://example.com/yasgui/
+ * resolveEndpointUrl("/sparql") // returns "https://example.com/sparql"
+ * resolveEndpointUrl("sparql") // returns "https://example.com/yasgui/sparql"
+ * resolveEndpointUrl("http://other.com/sparql") // returns "http://other.com/sparql"
+ */
+export function resolveEndpointUrl(url: string): string {
+  if (!url) return url;
+
+  // If URL already has a protocol (http: or https:), return as-is
+  if (url.startsWith("http://") || url.startsWith("https://")) {
+    return url;
+  }
+
+  // Build the base URL using current page's protocol and host
+  let fullUrl = `${window.location.protocol}//${window.location.host}`;
+
+  if (url.startsWith("/")) {
+    // Absolute path (starts with /)
+    fullUrl += url;
+  } else {
+    // Relative path - join with current page's directory
+    let currentDirectory = window.location.pathname;
+    // If pathname does not end with "/", treat it as a file and use its directory
+    if (!currentDirectory.endsWith("/")) {
+      const lastSlashIndex = currentDirectory.lastIndexOf("/");
+      currentDirectory = lastSlashIndex >= 0 ? currentDirectory.substring(0, lastSlashIndex + 1) : "/";
+    }
+    fullUrl += currentDirectory + url;
+  }
+
+  return fullUrl;
+}

test/unit/url-utils-test.ts

@@ -0,0 +1,86 @@
+import * as chai from "chai";
+import { describe, it, beforeEach, afterEach } from "mocha";
+
+import { resolveEndpointUrl } from "../../packages/yasgui/src/urlUtils.js";
+
+const expect = chai.expect;
+
+describe("URL utilities - resolveEndpointUrl", () => {
+  let originalWindow: any;
+
+  beforeEach(() => {
+    // Save the original window object if it exists
+    originalWindow = (global as any).window;
+  });
+
+  afterEach(() => {
+    // Restore the original window object
+    if (originalWindow) {
+      (global as any).window = originalWindow;
+    } else {
+      delete (global as any).window;
+    }
+  });
+
+  function mockWindow(url: string) {
+    const parsedUrl = new URL(url);
+    (global as any).window = {
+      location: {
+        protocol: parsedUrl.protocol,
+        host: parsedUrl.host,
+        hostname: parsedUrl.hostname,
+        port: parsedUrl.port,
+        pathname: parsedUrl.pathname,
+        href: url,
+      },
+    };
+  }
+
+  it("returns absolute URLs unchanged (http)", () => {
+    mockWindow("https://example.com/yasgui/");
+    const result = resolveEndpointUrl("http://example.com/sparql");
+    expect(result).to.equal("http://example.com/sparql");
+  });
+
+  it("returns absolute URLs unchanged (https)", () => {
+    mockWindow("https://example.com/yasgui/");
+    const result = resolveEndpointUrl("https://example.com/sparql");
+    expect(result).to.equal("https://example.com/sparql");
+  });
+
+  it("converts absolute path to full URL with current protocol and host", () => {
+    mockWindow("https://example.com/yasgui/index.html");
+    const result = resolveEndpointUrl("/sparql");
+    expect(result).to.equal("https://example.com/sparql");
+  });
+
+  it("converts relative path to full URL with current directory", () => {
+    mockWindow("https://example.com/yasgui/");
+    const result = resolveEndpointUrl("sparql");
+    expect(result).to.equal("https://example.com/yasgui/sparql");
+  });
+
+  it("uses https protocol when page is https", () => {
+    mockWindow("https://secure.example.com/app/");
+    const result = resolveEndpointUrl("/sparql");
+    expect(result).to.equal("https://secure.example.com/sparql");
+  });
+
+  it("uses http protocol when page is http", () => {
+    mockWindow("http://example.com/app/");
+    const result = resolveEndpointUrl("/sparql");
+    expect(result).to.equal("http://example.com/sparql");
+  });
+
+  it("handles empty string", () => {
+    mockWindow("https://example.com/app/");
+    const result = resolveEndpointUrl("");
+    expect(result).to.equal("");
+  });
+
+  it("includes port number if present", () => {
+    mockWindow("https://example.com:8080/app/");
+    const result = resolveEndpointUrl("/sparql");
+    expect(result).to.equal("https://example.com:8080/sparql");
+  });
+});