Skip to content

Commit b824a61

Browse files
committed
Fix TextBox horizontal scrollbar position when VerticalContentAlignment is set to Top
1 parent e5d0c3d commit b824a61

File tree

3 files changed

+6
-32
lines changed

3 files changed

+6
-32
lines changed

src/MainDemo.Wpf/Fields.xaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,12 +340,14 @@
340340

341341
<TextBox Height="100"
342342
VerticalAlignment="Top"
343+
VerticalContentAlignment="Top"
343344
materialDesign:HintAssist.Hint="This is a text area"
344345
AcceptsReturn="True"
345346
IsEnabled="{Binding Path=IsChecked, ElementName=MaterialDesignOutlinedTextBoxEnabledComboBox}"
346347
Style="{StaticResource MaterialDesignOutlinedTextBox}"
347-
TextWrapping="Wrap"
348-
VerticalScrollBarVisibility="Auto" />
348+
TextWrapping="NoWrap"
349+
VerticalScrollBarVisibility="Auto"
350+
HorizontalScrollBarVisibility="Auto" />
349351
</StackPanel>
350352
</smtx:XamlDisplay>
351353

src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.TextBox.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133

134134
<Grid x:Name="ContentGrid"
135135
MinHeight="16"
136-
VerticalAlignment="{TemplateBinding VerticalContentAlignment}">
136+
VerticalAlignment="Stretch">
137137
<Grid.ColumnDefinitions>
138138
<ColumnDefinition Width="Auto" />
139139
<ColumnDefinition Width="Auto" />
@@ -156,7 +156,7 @@
156156
<ScrollViewer x:Name="PART_ContentHost"
157157
Grid.Column="2"
158158
HorizontalAlignment="Stretch"
159-
VerticalAlignment="Center"
159+
VerticalAlignment="Stretch"
160160
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
161161
VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
162162
Panel.ZIndex="1"

tests/MaterialDesignThemes.UITests/WPF/TextBoxes/TextBoxTests.cs

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -536,34 +536,6 @@ public async Task TextBox_WithHintAndValidationError_RespectsPadding(string styl
536536
recorder.Success();
537537
}
538538

539-
[Test]
540-
[Arguments(VerticalAlignment.Stretch, VerticalAlignment.Stretch)]
541-
[Arguments(VerticalAlignment.Top, VerticalAlignment.Top)]
542-
[Arguments(VerticalAlignment.Bottom, VerticalAlignment.Bottom)]
543-
[Arguments(VerticalAlignment.Center, VerticalAlignment.Center)]
544-
[Description("Issue 3161")]
545-
public async Task TextBox_MultiLineAndFixedHeight_RespectsVerticalContentAlignment(VerticalAlignment alignment, VerticalAlignment expectedFloatingHintAlignment)
546-
{
547-
await using var recorder = new TestRecorder(App);
548-
549-
var stackPanel = await LoadXaml<StackPanel>($$"""
550-
<StackPanel>
551-
<TextBox Style="{StaticResource MaterialDesignFilledTextBox}"
552-
materialDesign:HintAssist.Hint="Hint text"
553-
VerticalContentAlignment="{{alignment}}"
554-
AcceptsReturn="True"
555-
Height="200" />
556-
</StackPanel>
557-
""");
558-
559-
IVisualElement<TextBox> textBox = await stackPanel.GetElement<TextBox>("/TextBox");
560-
IVisualElement<Grid> contentGrid = await textBox.GetElement<Grid>("ContentGrid");
561-
562-
await Assert.That(await contentGrid.GetVerticalAlignment()).IsEqualTo(expectedFloatingHintAlignment);
563-
564-
recorder.Success();
565-
}
566-
567539
[Test]
568540
[Description("Issue 3176")]
569541
public async Task ValidationErrorTemplate_WithChangingErrors_UpdatesValidation()

0 commit comments

Comments
 (0)