Conversation
Keboo
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3839
This PR modifies the
MaterialDesignMultiFloatingActionPopupBoxandMaterialDesignMultiFloatingActionSecondaryPopupBoxstyles that are causing the issue.The root cause of this seems more like a side-effect of using the
Ripplein a certain way, rather than an actual bug with theRipple. At least that is my assumption, based on the fact that we have special code for offsetting the ripple when there is inner content (see here).In most cases, we don't actually put content inside the
Ripplebut place it at the same level (i.e. "on top/below content"). I believe this is a case where that is desired as well. So this PR basically lifts theContentControlup so it is no longer a child of theRipple, but becomes a sibling instead.With fix:
