Skip to content

Fix off-center PopupBox ripple #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 1 commit into from
May 9, 2025
Merged

Fix off-center PopupBox ripple #3843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.PopupBox.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,17 +272,18 @@
Clip="{Binding ElementName=GeometryEllipse, Path=RenderedGeometry}"
ClipToBounds="True"
Focusable="False"
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}">
<!-- additional layer so we don't rotate the ripple directly which can cause jumpyness under certain layouts -->
<ContentControl Content="{TemplateBinding Content}"
ContentTemplate="{TemplateBinding ContentTemplate}"
Focusable="False"
RenderTransformOrigin=".5,.5">
<ContentControl.RenderTransform>
<RotateTransform x:Name="ContentRotateTransform" Angle="0" />
</ContentControl.RenderTransform>
</ContentControl>
</wpf:Ripple>
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
<!-- additional layer so we don't rotate the ripple directly which can cause jumpyness under certain layouts -->
<ContentControl Content="{TemplateBinding Content}"
ContentTemplate="{TemplateBinding ContentTemplate}"
Focusable="False"
HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"
VerticalAlignment="{TemplateBinding VerticalContentAlignment}"
RenderTransformOrigin=".5,.5">
<ContentControl.RenderTransform>
<RotateTransform x:Name="ContentRotateTransform" Angle="0" />
</ContentControl.RenderTransform>
</ContentControl>
<Ellipse x:Name="GeometryEllipse"
Fill="Transparent"
Focusable="False"
Expand Down
Loading