Prefer TemplateBinding over Binding with RelativeSource#3930
Merged
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom Sep 27, 2025
Merged
Prefer TemplateBinding over Binding with RelativeSource#3930Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
Conversation
Keboo
approved these changes
Sep 26, 2025
Member
Keboo
left a comment
Keboo
left a comment
There was a problem hiding this comment.
My best guess on the difference in behavior is because the second element is getting hidden with its opacity set to 0. But that is more a guess than anything.
Changes `ContentSite` border to be unnamed and binds `ExpandDirection` directly from the `TemplateBinding`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3890
This fixes a runtime binding error.
The exact same binding I fixed in this PR is also used a few lines above, however that binding does not throw a binding error (I'm honestly not sure why 😆 ):
https://github.com/corvinsz/MaterialDesignInXamlToolkit/blob/6b115b0cb43fa18142c78429f30ec7dcc7585552/src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.Expander.xaml?plain=1#L310