Skip to content

fix: Clip ripple effect for default Button style in materialDesign:PopupBox #3983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 2 commits into from
Dec 19, 2025
+1 −1
Merged

fix: Clip ripple effect for default Button style in materialDesign:PopupBox #3983

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77e135d
fix: Clip ripple effect for default Button style in `materialDesign:P…
corvinsz Dec 11, 2025
92991cc
refactor: leverage ClipToBounds instead of a custom converter
corvinsz Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.PopupBox.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="{x:Type Button}">
<Grid>
<Grid x:Name="rootGrid">
<VisualStateManager.VisualStateGroups>
<VisualStateGroup Name="CommonStates">
<VisualStateGroup.Transitions>
Expand Down Expand Up @@ -57,7 +57,14 @@
ContentTemplateSelector="{TemplateBinding ContentTemplateSelector}"
Feedback="{TemplateBinding Foreground, Converter={x:Static converters:BrushRoundConverter.Instance}}"
Focusable="False"
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" >
<wpf:Ripple.Clip>
Comment thread
corvinsz marked this conversation as resolved.
Outdated
<MultiBinding Converter="{x:Static converters:BorderClipConverter.Instance}">
<Binding ElementName="rootGrid" Path="ActualWidth" />
<Binding ElementName="rootGrid" Path="ActualHeight" />
</MultiBinding>
</wpf:Ripple.Clip>
</wpf:Ripple>
</Grid>
</ControlTemplate>
</Setter.Value>
Expand Down
Loading