Fix TabControl issue where tabs (in a dialog) stopped working#4065
Open
nicolaihenriksen wants to merge 1 commit into
Open
Fix TabControl issue where tabs (in a dialog) stopped working#4065nicolaihenriksen wants to merge 1 commit into
nicolaihenriksen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4063
The hack that was added to avoid multi-click/keypress navigation from screwing with the animation, was causing some issues in particular when used inside of a Popup - e.g.
DialogHostwith the default style. I believe this is because thePopupapparently setsPopupRoot.IsHitTestVisible=Falsewhen it closes (See here). So in cases where the dialog reopens with the same content, their initial value forIsHitTestVisiblewill be false.To mitigate this issue, the hack (and the animation) is now skipped in case
TabControl.IsHitTestVisible == Falsewhen the animation is intended to occur. This avoids the issue the OP was experiencing, and still works in the "normal" use cases.