Default enable_observability to true in the simple examples#222
Draft
bobbyiliev wants to merge 1 commit into
Draft
Default enable_observability to true in the simple examples#222bobbyiliev wants to merge 1 commit into
bobbyiliev wants to merge 1 commit into
Conversation
alex-hunt-materialize
approved these changes
Jun 2, 2026
alex-hunt-materialize
left a comment
alex-hunt-materialize
left a comment
Contributor
There was a problem hiding this comment.
@Alphadelta14 We may need to do migrations once your monitoring stack changes are ready. These could already have been enabled manually, so we have to do that regardless of this change to the default.
Member
|
would prefer this lands a bit later. i know I need to support migrations but the less in place, the better. |
jubrad
approved these changes
Jun 2, 2026
Member
|
@bobbyiliev let's hold off on merging till @Alphadelta14 gives the 👍 |
Collaborator
Author
|
Sounds good, converting this to a draft for the moment in this case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #167 (comment).