repeat_row: Fix SingleTimeMonotonic to take into account FlatMap's TableFunc's preserves_monotonicity#36183
Open
ggevay wants to merge 5 commits intoMaterializeInc:mainfrom
Open
Conversation
Also disallow it in constructs that are implemented by WITH ORDINALITY under the hood: - ROWS FROM - implicit ROWS FROM, i.e., multiple table functions in a SELECT clause
ggevay
added
T-correctness
ggevay
changed the title
SingleTimeMonotonic to take into account FlatMap's TableFunc's preserves_monotonicityrepeat_row: Fix SingleTimeMonotonic to take into account FlatMap's TableFunc's preserves_monotonicity
ggevay
force-pushed
the
repeat_row-2-SingleTimeMonotonic
branch
from
07f247c to
bacc017
Compare
…`preserves_monotonicity`
ggevay
force-pushed
the
repeat_row-2-SingleTimeMonotonic
branch
from
bacc017 to
7493b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the 2. PR in the
repeat_rowproductionization work stream. This is on top of #36174. Resolves SQL-162.Fixes a part of https://github.com/MaterializeInc/database-issues/issues/11310, namely that
RelaxMustConsolidate/SingleTimeMonotonicwas not taking into account table functions'preserves_monotonicity. (can only happenrepeat_rowcurrently)Only the last 2 commits are new:
must_consolidate.(Will shortly submit a PR also about fixing
refine_single_time_operator_selection, because themonotonicflag on theReduceis also wrong in this same plan. That's a slightly more involved fix, so I'd like to put that into a separate PR.)