mysql: log row shape on decoding error#36190
Open
martykulma wants to merge 4 commits intoMaterializeInc:mainfrom
Open
mysql: log row shape on decoding error#36190martykulma wants to merge 4 commits intoMaterializeInc:mainfrom
martykulma wants to merge 4 commits intoMaterializeInc:mainfrom
Conversation
ublubu
reviewed
Apr 21, 2026
| for (binlog_row, diff) in updates.into_iter().flatten() { | ||
| let row = mysql_async::Row::try_from(binlog_row)?; | ||
| for (output, row_val) in outputs.iter().repeat_clone(row) { | ||
| let row_shape = describe_row_shape(&row_val, &output.desc); |
Contributor
There was a problem hiding this comment.
I'm guessing we aren't bothered by creating all these strings.
Contributor
Author
There was a problem hiding this comment.
good catch - I'll push it down to only get built in pack_mysql_row
Contributor
Author
There was a problem hiding this comment.
@patrickwwbutler ptal - moving the error handling further down required me to make some additional changes that you were probably also making.
I ran with the changes in 11312 and it passed successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If MySQL fails to decode a binlog row, it unfortunately doesn't provide much information. This adds additional logging that provide the row shape information for debugging.
In pushing this further down into
pack_mysql_row, I did some additional refactoring.Sample output: