console: surface OIDC sign-in failures on the login page#36193
Open
leedqin wants to merge 1 commit intoMaterializeInc:mainfrom
Open
console: surface OIDC sign-in failures on the login page#36193leedqin wants to merge 1 commit intoMaterializeInc:mainfrom
leedqin wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
* Add `OidcCallback` route component so IdP callback errors render
instead of an indefinite loading spinner.
* Add `AuthError::OidcFailed` carrying the sanitized `OidcError::Display`
in the 401 body, so environmentd token rejections can be surfaced to
the user without leaking internal config.
* Wire the 401 interceptor to post a one-shot `{reason, detail}` message
to `sessionStorage`; the login page renders it as an `Alert`
leedqin
force-pushed
the
console-improve-oidc-errors
branch
from
53dd542 to
ecb9e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Addressing SSO Feedback to show better error messages in the console if there are SSO failures and not have a confusing user experience. Fixes CNS-53
Description
Verification
When the sign in failed and if the user is not part of the organization
When OIDC might not be configured properly
