arrow-util: check for overflow in interval micros-to-nanos conversion#36226
Open
def- wants to merge 1 commit intoMaterializeInc:mainfrom
Open
arrow-util: check for overflow in interval micros-to-nanos conversion#36226def- wants to merge 1 commit intoMaterializeInc:mainfrom
def- wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
The `IntervalMonthDayNano` builder path introduced in MaterializeInc#35753 computed `iv.micros * 1_000` without an overflow check. Intervals with `|micros| > i64::MAX / 1000` wrap in release and panic in debug. Switch to `checked_mul` and bail with an error instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IntervalMonthDayNanobuilder path introduced in #35753 computediv.micros * 1_000without an overflow check. Intervals with|micros| > i64::MAX / 1000wrap in release and panic in debug. Switch tochecked_muland bail with an error instead.