ore: fix OpenTelemetryRateLimitingFilter suppressing every event#36227
Open
def- wants to merge 1 commit intoMaterializeInc:mainfrom
Open
ore: fix OpenTelemetryRateLimitingFilter suppressing every event#36227def- wants to merge 1 commit intoMaterializeInc:mainfrom
def- wants to merge 1 commit intoMaterializeInc:mainfrom
Conversation
The filter's `should_log` ran in both `Filter::enabled` and `Filter::event_enabled`. tracing-subscriber calls both per event for a per-layer filter: the first call inserted the callsite into `last_logged`, the second saw it within the backoff window and returned false — so every OpenTelemetry internal log was dropped, including the first. Make `enabled` non-mutating and keep the rate-limit decision in `event_enabled`. Introduced in MaterializeInc#34850 (commit 6e16efb "rate limit opentelemetry internal logs"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alex-hunt-materialize
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter's
should_logran in bothFilter::enabledandFilter::event_enabled. tracing-subscriber calls both per event for a per-layer filter: the first call inserted the callsite intolast_logged, the second saw it within the backoff window and returned false — so every OpenTelemetry internal log was dropped, including the first. Makeenablednon-mutating and keep the rate-limit decision inevent_enabled.Introduced in #34850 (commit 6e16efb "rate limit opentelemetry internal logs").