Skip to content

ore: fix OpenTelemetryRateLimitingFilter suppressing every event #36227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
def- wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

ore: fix OpenTelemetryRateLimitingFilter suppressing every event #36227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ore/src/tracing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,12 +865,17 @@ impl<S> tracing_subscriber::layer::Filter<S> for OpenTelemetryRateLimitingFilter
where
S: tracing::Subscriber + for<'lookup> LookupSpan<'lookup>,
{
// NB: `enabled` must stay non-mutating. tracing-subscriber calls both `enabled`
// and then `event_enabled` for every event; if `should_log` ran in both, the
// first call would insert the callsite into `last_logged` and the second would
// see it within the backoff window and suppress — dropping every OpenTelemetry
// event, including the first.
fn enabled(
&self,
metadata: &tracing::Metadata<'_>,
_metadata: &tracing::Metadata<'_>,
_ctx: &tracing_subscriber::layer::Context<'_, S>,
) -> bool {
self.should_log(metadata)
true
}

fn event_enabled(
Expand Down
Loading