compute: capture arrangement_dictionary_compression on the replica#37290
Open
antiguru wants to merge 1 commit into
Open
compute: capture arrangement_dictionary_compression on the replica#37290antiguru wants to merge 1 commit into
antiguru wants to merge 1 commit into
Conversation
antiguru
force-pushed
the
claude/funny-volta-hduk2q
branch
2 times, most recently
from
c505fd7 to
41027a5
Compare
antiguru
commented
Jun 25, 2026
antiguru
force-pushed
the
claude/funny-volta-hduk2q
branch
from
41027a5 to
c50a7af
Compare
antiguru
commented
Jun 25, 2026
antiguru
force-pushed
the
claude/funny-volta-hduk2q
branch
from
c50a7af to
16786f9
Compare
`arrangement_dictionary_compression` was passed via `CreateInstance`, baked into `InstanceConfig` from the controller's dyncfg at replica creation. After an environmentd restart the controller re-derives the value, so if the flag was flipped in between, the reconciled `CreateInstance` carried a different value than the running replica was created with -- a difference that risks an unnecessary replica restart. Move the value out of `CreateInstance` entirely. The replica now captures the first value it observes from a configuration update (in `handle_update_configuration`) and holds it fixed for its lifetime, mirroring it into the process-global `DICTIONARY_COMPRESSION`. The reduced command history always orders `UpdateConfiguration` before any `CreateDataflow`, so the value is latched before any arrangement is built. The flag is also declared `ParameterScope::Replica` so it can be overridden per-replica. Drops `arrangement_dictionary_compression` from `InstanceConfig` and `ReplicaConfig` (and the controller capture / specialize_command path), and the clusterd test driver now pushes it as a dyncfg instead. Fixes CLU-135. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LBErWUhZR4sBuEfGStb5FP
antiguru
force-pushed
the
claude/funny-volta-hduk2q
branch
from
16786f9 to
6b71709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arrangement_dictionary_compressionwas passed viaCreateInstance, baked intoInstanceConfigfrom the controller's dyncfg at replica creation. After anenvironmentdrestart the controller re-derives the value, so a flag flip in between made the reconciledCreateInstancediffer from what the running replica was created with, risking an unnecessary replica restart.This moves the value out of
CreateInstance. The replica now captures the first value it observes from a configuration update and holds it fixed for its lifetime, mirroring it into the process-globalDICTIONARY_COMPRESSION. The reduced command history always ordersUpdateConfigurationbefore anyCreateDataflow, so the value is latched before any arrangement is built. The flag is also declaredParameterScope::Replicaso it can be overridden per-replica.Fixes CLU-135.