upgrades

Author: MathewBensonCode

Obelisk/CMakeLists.txt

@@ -33,8 +33,6 @@ target_include_directories (${TARGET_NAME}
         ${ENLISTMENT_ROOT}/ZEngine
 )
 
-target_precompile_headers(${TARGET_NAME} PRIVATE pch.h)
-
 target_compile_definitions(${TARGET_NAME}
     PRIVATE
         NOMINMAX

Obelisk/pch.h

@@ -42,8 +42,6 @@ target_include_directories (${TARGET_NAME}
         ./Managers
 )
 
-target_precompile_headers(${TARGET_NAME} PRIVATE pch.h)
-
 target_compile_definitions(${TARGET_NAME}
     PRIVATE
         NOMINMAX

Tetragrama/CMakeLists.txt

@@ -51,8 +51,6 @@ target_include_directories (zEngineLib
 		./Serializers
 )
 
-target_precompile_headers(zEngineLib PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/pch.h)
-
 if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")
 	target_compile_definitions (zEngineLib PUBLIC ENABLE_VULKAN_VALIDATION_LAYER)
 endif()

Tetragrama/pch.h

@@ -494,10 +494,12 @@ namespace ZEngine::Core::Maths
         translation    = Vec3f(LocalMatrix[3].x, LocalMatrix[3].y, LocalMatrix[3].z);
         LocalMatrix[3] = Vec4f(0, 0, 0, LocalMatrix[3].w);
 
-        Vec3f Row[3], Pdum3;
-        for (int i = 0; i < 3; ++i)
-            for (int j = 0; j < 3; ++j)
+        std::array<Vec3f, 3> Row{};
+        for (int i = 0; i < 3; ++i) {
+            for (int j = 0; j < 3; ++j) {
                 Row[i][j] = LocalMatrix(i, j);
+}
+}
 
         scale.x    = Row[0].magnitude();
         Row[0]     = Row[0].normalize();
@@ -588,4 +590,4 @@ namespace ZEngine::Core::Maths
         return &vec.x;
     }
 
-} // namespace ZEngine::Core::Maths
+} // namespace ZEngine::Core::Maths

ZEngine/ZEngine/CMakeLists.txt

@@ -121,7 +121,7 @@ namespace ZEngine::Hardwares
         Array<VkImage> swapchain_images = {};
         swapchain_images.init(scratch.Arena, SwapchainImageCount, SwapchainImageCount);
         ZENGINE_VALIDATE_ASSERT(vkGetSwapchainImagesKHR(Device->LogicalDevice, SwapchainHandle, &SwapchainImageCount, swapchain_images.data()) == VK_SUCCESS, "Failed to get VkImages from Swapchain")
-        for (int i = 0; i < SwapchainImageCount; ++i)
+        for (auto i = 0U; i < SwapchainImageCount; ++i)
         {
             SwapchainImageViews[i] = Device->CreateImageView(swapchain_images[i], Device->SurfaceFormat.format, VK_IMAGE_VIEW_TYPE_2D, VK_IMAGE_ASPECT_COLOR_BIT);
 

ZEngine/ZEngine/Core/Maths/Matrix.h

@@ -100,7 +100,7 @@ namespace ZEngine::Hardwares
         VkSampler     Sampler{VK_NULL_HANDLE};
         VmaAllocation Allocation{nullptr};
         // clang-format off
-        operator bool() const
+        explicit operator bool() const
         {
             return (Handle != VK_NULL_HANDLE);
         }
@@ -291,8 +291,8 @@ namespace ZEngine::Hardwares
 
         explicit UniformBuffer(const UniformBuffer& rhs) = delete;
 
-        explicit UniformBuffer(UniformBuffer& rhs)
-        {
+        UniformBuffer(UniformBuffer& rhs)
+         : IGraphicBuffer(rhs) {
             this->m_device     = rhs.m_device;
             this->m_total_size = rhs.m_total_size;
 

ZEngine/ZEngine/Hardwares/DeviceSwapchain.cpp

@@ -18,14 +18,14 @@ namespace ZEngine::Helpers
     struct Handle
     {
         uint64_t Index      = UINT64_MAX;
-        uint64_t Generation = 0u;
+        uint64_t Generation = 0U;
 
-        bool     Valid() const
+        [[nodiscard]] bool     Valid() const
         {
             return Index != UINT64_MAX;
         }
 
-        operator bool() const
+        explicit operator bool() const
         {
             return Valid();
         }
@@ -36,7 +36,7 @@ namespace ZEngine::Helpers
     {
         union FreeHead
         {
-            struct
+            struct storage
             {
                 uint32_t index;
                 uint32_t tag;

ZEngine/ZEngine/Hardwares/VulkanDevice.h

@@ -8,6 +8,7 @@
 #include <spdlog/async_logger.h>
 #include <spdlog/details/thread_pool.h>
 #include <spdlog/sinks/rotating_file_sink.h>
+#include <filesystem>
 
 using namespace ZEngine::Core::Memory;