remove pch and fix includes

MathewBensonCode · MathewBensonCode · commit 7a288f4708bd · 2026-05-18T15:37:25.000+03:00
diff --git a/Obelisk/CMakeLists.txt b/Obelisk/CMakeLists.txt
@@ -33,8 +33,6 @@ target_include_directories (${TARGET_NAME}
         ${ENLISTMENT_ROOT}/ZEngine
 )
 
-target_precompile_headers(${TARGET_NAME} PRIVATE pch.h)
-
 target_compile_definitions(${TARGET_NAME}
     PRIVATE
         NOMINMAX
diff --git a/Resources/CMakeLists.txt b/Resources/CMakeLists.txt
@@ -19,7 +19,7 @@ foreach(VertexShader ${VertexShaders})
       cmake_path(APPEND_STRING shaderfilename "_vertex.spv" OUTPUT_VARIABLE VertexShaderOutputFileName )
       cmake_path(APPEND ShaderOutputPath ${VertexShaderOutputFileName} OUTPUT_VARIABLE VertexShaderOutputPath)
 
-      add_custom_target("Compile-${shaderfilename}-vertex" ALL COMMAND glslang-standalone "-I${ShaderPath}" "-V" ${Flags} "-o" "${VertexShaderOutputPath}" "${VertexShader}")
+      add_custom_target("Compile-${shaderfilename}-vertex" ALL COMMAND glslang::glslang-standalone "-I${ShaderPath}" "-V" ${Flags} "-o" "${VertexShaderOutputPath}" "${VertexShader}")
 
     
 endforeach()
diff --git a/Tetragrama/CMakeLists.txt b/Tetragrama/CMakeLists.txt
@@ -42,8 +42,6 @@ target_include_directories (${TARGET_NAME}
         ./Managers
 )
 
-target_precompile_headers(${TARGET_NAME} PRIVATE pch.h)
-
 target_compile_definitions(${TARGET_NAME}
     PRIVATE
         NOMINMAX
diff --git a/Tetragrama/Components/DockspaceUIComponent.cpp b/Tetragrama/Components/DockspaceUIComponent.cpp
@@ -8,6 +8,11 @@
 #include <ZEngine/Logging/LoggerDefinition.h>
 #include <fmt/format.h>
 #include <imgui/imgui_internal.h>
+#include <atomic>
+#include <filesystem>
+#include <future>
+#include <string_view>
+#include <vector>
 
 namespace fs = std::filesystem;
 
diff --git a/Tetragrama/Components/HierarchyViewUIComponent.cpp b/Tetragrama/Components/HierarchyViewUIComponent.cpp
@@ -8,6 +8,7 @@
 #include <ZEngine/Windows/Inputs/KeyCodeDefinition.h>
 #include <ZEngine/Windows/Inputs/Keyboard.h>
 #include <ZEngine/Windows/Inputs/Mouse.h>
+#include <stack>
 
 using namespace ZEngine;
 using namespace ZEngine::Helpers;
diff --git a/Tetragrama/Components/ProjectViewUIComponent.cpp b/Tetragrama/Components/ProjectViewUIComponent.cpp
@@ -3,6 +3,8 @@
 #include <ProjectViewUIComponent.h>
 #include <ZEngine/Helpers/MemoryOperations.h>
 #include <imgui.h>
+#include <filesystem>
+#include <fstream>
 
 using namespace ZEngine::Helpers;
 
diff --git a/Tetragrama/Components/ProjectViewUIComponent.h b/Tetragrama/Components/ProjectViewUIComponent.h
@@ -2,6 +2,7 @@
 #include <UIComponent.h>
 #include <ZEngine/Core/Memory/Allocator.h>
 #include <ZEngine/Importers/AssetTypes.h>
+#include <filesystem>
 
 namespace Tetragrama::Components
 {
diff --git a/Tetragrama/Components/SceneViewportUIComponent.cpp b/Tetragrama/Components/SceneViewportUIComponent.cpp
@@ -8,6 +8,7 @@
 /**/
 #include <Editor.h>
 #include <ImGuizmo/ImGuizmo.h>
+#include <filesystem>
 
 using namespace Tetragrama::Components::Event;
 using namespace ZEngine::Rendering::Renderers;
diff --git a/Tetragrama/Editor.cpp b/Tetragrama/Editor.cpp
@@ -4,6 +4,9 @@
 #include <Messengers/Messenger.h>
 #include <fmt/format.h>
 #include <nlohmann/json.hpp>
+#include <filesystem>
+#include <fstream>
+#include <string>
 
 using namespace ZEngine;
 using namespace ZEngine::Core::Containers;
diff --git a/Tetragrama/Serializers/EditorSceneSerializer.cpp b/Tetragrama/Serializers/EditorSceneSerializer.cpp
@@ -4,6 +4,7 @@
 #include <ZEngine/Helpers/SerializerCommonHelper.h>
 #include <ZEngine/Helpers/ThreadPool.h>
 #include <fmt/format.h>
+#include <fstream>
 
 using namespace ZEngine::Helpers;
 using namespace ZEngine::Core::Containers;
diff --git a/ZEngine/ZEngine/CMakeLists.txt b/ZEngine/ZEngine/CMakeLists.txt
@@ -51,8 +51,6 @@ target_include_directories (zEngineLib
 		./Serializers
 )
 
-target_precompile_headers(zEngineLib PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/pch.h)
-
 if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")
 	target_compile_definitions (zEngineLib PUBLIC ENABLE_VULKAN_VALIDATION_LAYER)
 endif()
diff --git a/ZEngine/ZEngine/Hardwares/AsyncResourceLoader.cpp b/ZEngine/ZEngine/Hardwares/AsyncResourceLoader.cpp
@@ -3,6 +3,7 @@
 #include <Importers/EnvironmentMapImporter.h>
 #include <Rendering/Buffers/Bitmap.h>
 #include <VulkanDevice.h>
+#include <filesystem>
 
 #define STB_IMAGE_IMPLEMENTATION
 #ifdef __GNUC__
diff --git a/ZEngine/ZEngine/Hardwares/VulkanDevice.cpp b/ZEngine/ZEngine/Hardwares/VulkanDevice.cpp
@@ -13,6 +13,7 @@
 #include <Rendering/Renderers/RenderPasses/Attachment.h>
 #include <Rendering/Renderers/RenderPasses/RenderPass.h>
 #include <Windows/CoreWindow.h>
+#include <filesystem>
 
 using namespace std::chrono_literals;
 using namespace ZEngine::Rendering::Primitives;
diff --git a/ZEngine/ZEngine/Helpers/SerializerCommonHelper.h b/ZEngine/ZEngine/Helpers/SerializerCommonHelper.h
@@ -165,4 +165,4 @@ namespace ZEngine::Helpers
             map.insert(key, val);
         }
     }
-} // namespace ZEngine::Helpers
+} // namespace ZEngine::Helpers
diff --git a/ZEngine/ZEngine/Importers/AssimpImporter.cpp b/ZEngine/ZEngine/Importers/AssimpImporter.cpp
@@ -4,6 +4,8 @@
 #include <Helpers/ThreadPool.h>
 #include <assimp/postprocess.h>
 #include <fmt/format.h>
+#include <filesystem>
+#include <fstream>
 
 using namespace ZEngine::Helpers;
 using namespace ZEngine::Rendering::Meshes;
diff --git a/ZEngine/ZEngine/Importers/EnvironmentMapImporter.cpp b/ZEngine/ZEngine/Importers/EnvironmentMapImporter.cpp
@@ -2,6 +2,7 @@
 #include <EnvironmentMapImporter.h>
 #include <Helpers/ThreadPool.h>
 #include <fmt/format.h>
+#include <filesystem>
 
 // stb_image implementation is defined once in AsyncResourceLoader.cpp.
 #include <stb/stb_image.h>
diff --git a/ZEngine/ZEngine/Importers/IAssetImporter.cpp b/ZEngine/ZEngine/Importers/IAssetImporter.cpp
@@ -1,6 +1,8 @@
 #include <Core/Containers/Array.h>
 #include <Helpers/SerializerCommonHelper.h>
 #include <IAssetImporter.h>
+#include <filesystem>
+#include <fstream>
 
 using namespace uuids;
 using namespace ZEngine::Helpers;
diff --git a/ZEngine/ZEngine/Logging/Logger.cpp b/ZEngine/ZEngine/Logging/Logger.cpp
@@ -8,6 +8,7 @@
 #include <spdlog/async_logger.h>
 #include <spdlog/details/thread_pool.h>
 #include <spdlog/sinks/rotating_file_sink.h>
+#include <filesystem>
 
 using namespace ZEngine::Core::Memory;
 
diff --git a/ZEngine/ZEngine/Rendering/Buffers/Bitmap.h b/ZEngine/ZEngine/Rendering/Buffers/Bitmap.h
@@ -202,8 +202,8 @@ namespace ZEngine::Rendering::Buffers
                         const int                         U2    = ZEngine::Core::Maths::clamp(U1 + 1, 0, clamped_width);
                         const int                         V2    = ZEngine::Core::Maths::clamp(V1 + 1, 0, clamped_height);
 
-                        const float                       s     = Uf - U1;
-                        const float                       t     = Vf - V1;
+                        const float                       s     = Uf - static_cast<float>(U1);
+                        const float                       t     = Vf - static_cast<float>(V1);
 
                         const ZEngine::Core::Maths::Vec4f A     = input_map.GetPixel(U1, V1);
                         const ZEngine::Core::Maths::Vec4f B     = input_map.GetPixel(U2, V1);
@@ -302,4 +302,4 @@ namespace ZEngine::Rendering::Buffers
         BitmapFormat         Format  = BitmapFormat::UNSIGNED_BYTE;
         std::vector<uint8_t> Buffer  = {};
     };
-} // namespace ZEngine::Rendering::Buffers
+} // namespace ZEngine::Rendering::Buffers
diff --git a/ZEngine/ZEngine/Rendering/Buffers/BufferLayout.h b/ZEngine/ZEngine/Rendering/Buffers/BufferLayout.h
@@ -1,4 +1,5 @@
 #pragma once
+#include <cstdint>
 #include <initializer_list>
 #include <string>
 #include <string_view>
diff --git a/ZEngine/ZEngine/Rendering/Renderers/ImGUIRenderer.cpp b/ZEngine/ZEngine/Rendering/Renderers/ImGUIRenderer.cpp
@@ -5,6 +5,7 @@
 #include <backends/imgui_impl_glfw.h>
 #include <backends/imgui_impl_vulkan.h>
 #include <ImGuizmo/ImGuizmo.h>
+#include <filesystem>
 // clang-format on
 
 using namespace ZEngine::Hardwares;
diff --git a/ZEngine/ZEngine/Rendering/Shaders/Compilers/ShaderFileGenerator.cpp b/ZEngine/ZEngine/Rendering/Shaders/Compilers/ShaderFileGenerator.cpp
@@ -1,6 +1,9 @@
 #include <Core/Coroutine.h>
 #include <Logging/LoggerDefinition.h>
 #include <Rendering/Shaders/Compilers/ShaderFileGenerator.h>
+#include <filesystem>
+#include <fstream>
+#include <string>
 
 namespace ZEngine::Rendering::Shaders::Compilers
 {
@@ -23,9 +26,13 @@ namespace ZEngine::Rendering::Shaders::Compilers
     {
         std::filesystem::path file_path;
         if (information_list.Type == ShaderType::VERTEX)
+        {
             file_path = std::filesystem::path(outputDirectory) / fmt::format("{}_vertex.spv", information_list.Name);
+        }
         if (information_list.Type == ShaderType::FRAGMENT)
+        {
             file_path = std::filesystem::path(outputDirectory) / fmt::format("{}_fragment.spv", information_list.Name);
+        }
 
         return file_path.string();
     }
diff --git a/ZEngine/ZEngine/Serializers/GraphicScene3DSerializer.cpp b/ZEngine/ZEngine/Serializers/GraphicScene3DSerializer.cpp
@@ -12,6 +12,7 @@
 #include <Rendering/Materials/StandardMaterial.h>
 #include <Rendering/Textures/Texture.h>
 #include <Serializers/GraphicScene3DSerializer.h>
+#include <fstream>
 
 using namespace ZEngine::Rendering::Materials;
 using namespace ZEngine::Rendering::Components;
@@ -30,6 +31,7 @@ namespace YAML
             node.push_back(value.x);
             node.push_back(value.y);
             node.push_back(value.z);
+            return node;
         }
 
         static bool decode(const Node& node, Maths::Vec3f& value)
@@ -56,6 +58,7 @@ namespace YAML
             node.push_back(value.y);
             node.push_back(value.z);
             node.push_back(value.w);
+            return node;
         }
 
         static bool decode(const Node& node, Maths::Vec4f& value)
diff --git a/ZEngine/ZEngine/ZEngineDef.h b/ZEngine/ZEngine/ZEngineDef.h
@@ -12,7 +12,7 @@
 #include <signal.h>
 #define ZENGINE_DEBUG_BREAK() __builtin_trap();
 #else
-#include <signal.h>
+#include <csignal>
 #define ZENGINE_DEBUG_BREAK() raise(SIGTRAP);
 #endif
 
@@ -104,7 +104,7 @@
 #define ASSET_FILE_VERSION                                     MAKE_VERSION(1, 0, 0)
 #define SCENE_FILE_VERSION                                     MAKE_VERSION(1, 0, 0)
 
-typedef const char* cstring;
+using cstring = const char*;
 
 #ifdef __cpp_lib_hardware_interference_size
 #include <atomic>
diff --git a/dependencies.cmake b/dependencies.cmake
@@ -203,7 +203,7 @@ FetchContent_MakeAvailable(
 
 set(IMGUIDIR ${FETCHCONTENT_BASE_DIR}/imgui)
 
-add_library(imgui STATIC)
+add_library(imgui STATIC EXCLUDE_FROM_ALL)
 
 target_sources(
   imgui
@@ -225,7 +225,7 @@ target_compile_definitions(imgui PUBLIC GLFW_INCLUDE_VULKAN IMGUI_DEFINE_MATH_OP
 
 target_link_libraries(imgui PRIVATE glfw Vulkan::Headers Vulkan::Loader)
 
-add_library(imguizmo STATIC)
+add_library(imguizmo STATIC EXCLUDE_FROM_ALL)
 
 target_sources(imguizmo
     PRIVATE ${FETCHCONTENT_BASE_DIR}/ImGuizmo/ImGuizmo.cpp)
@@ -235,7 +235,7 @@ target_include_directories(imguizmo
 
 target_link_libraries(imguizmo PUBLIC imgui)
 
-add_library(External_libs INTERFACE)
+add_library(External_libs INTERFACE EXCLUDE_FROM_ALL)
 
 target_include_directories(External_libs
     INTERFACE
@@ -301,7 +301,7 @@ if(${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
         OPTIMIZE
     )
 
-    add_library(imported::cppwinrt_headers INTERFACE IMPORTED)
+    add_library(imported::cppwinrt_headers INTERFACE)
     target_include_directories(imported::cppwinrt_headers INTERFACE
         ${CMAKE_BINARY_DIR}/__winrt
     )
diff --git a/vcpkg.json b/vcpkg.json
@@ -1,27 +1,31 @@
 {
-    "dependencies": [
-        "fmt",
-        "spirv-tools",
-        "spirv-headers",
-        "assimp",
-        {
-            "name": "glslang",
-            "features": [
-                "opt",
-                "tools"
-            ]
-        },
-        "nlohmann-json",
-        "gtest",
-        "glfw3",
-        "spdlog",
-        "entt",
-        "stduuid",
-        "yaml-cpp",
-        "spirv-cross",
-        "cli11",
-        "vulkan-headers",
-        "vulkan-loader",
-        "vulkan-memory-allocator"
-    ]
+  "dependencies": [
+    "fmt",
+    "spirv-tools",
+    "spirv-headers",
+    "assimp",
+    {
+      "name": "glslang",
+      "features": [
+        "opt",
+        "tools"
+      ]
+    },
+    "nlohmann-json",
+    "gtest",
+    "glfw3",
+    "spdlog",
+    "entt",
+    "stduuid",
+    "yaml-cpp",
+    "spirv-cross",
+    "cli11",
+    "vulkan-headers",
+    "vulkan-loader",
+    "vulkan-memory-allocator"
+  ],
+  "builtin-baseline": "495848814af4cc2760e70f7440c2dbe66d3ff196",
+  "overrides" : [
+
+  ]
 }

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,6 @@ target_include_directories (${TARGET_NAME}`
`33`	`33`	`${ENLISTMENT_ROOT}/ZEngine`
`34`	`34`	`)`
`35`	`35`
`36`		`-target_precompile_headers(${TARGET_NAME} PRIVATE pch.h)`
`37`		`-`
`38`	`36`	`target_compile_definitions(${TARGET_NAME}`
`39`	`37`	`PRIVATE`
`40`	`38`	`NOMINMAX`
Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,6 @@ target_include_directories (${TARGET_NAME}`
`42`	`42`	`./Managers`
`43`	`43`	`)`
`44`	`44`
`45`		`-target_precompile_headers(${TARGET_NAME} PRIVATE pch.h)`
`46`		`-`
`47`	`45`	`target_compile_definitions(${TARGET_NAME}`
`48`	`46`	`PRIVATE`
`49`	`47`	`NOMINMAX`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`#include <UIComponent.h>`
`3`	`3`	`#include <ZEngine/Core/Memory/Allocator.h>`
`4`	`4`	`#include <ZEngine/Importers/AssetTypes.h>`
	`5`	`+#include <filesystem>`
`5`	`6`
`6`	`7`	`namespace Tetragrama::Components`
`7`	`8`	`{`