Independent FullForm#1316
Merged
Merged
Conversation
fullform
Member
|
Let's defer this until after a release, which I think may happen this weekend. |
Contributor
Author
|
Sure. I just put this here in relation with the other PR. |
mmatera
force-pushed
the
makeboxes_refactor_2025_step_0p5
branch
from
February 9, 2025 22:11
3b54e1b to
74bb87c
Compare
rocky
reviewed
Feb 11, 2025
Member
|
It would be very useful to add some tests that exercise and show in isolation what is going on here. |
Member
@mmatera Is it correct that there is no user-facing change that is observed, but instead these changes are purely organizational and internal? |
Member
|
LGTM |
Contributor
Author
|
Yep, it is just a way to decouple Full form of the other formatting. This helps to debug the other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful to handle the FullForm outside the evaluation process, for example, in debugging, or as a last resource with the standard evaluation process fails.