Commit 6427c8d
authored
fix: Multi touch flickering issue (#392)
## Description
This PR fixes multi touch flickering issue caused by the `handleDragEnd`
being called on the cancelled gesture. The second touch gesture was
properly ignored and failed but it called `handleDragEnd` as this method
is always called in the `onFinalize` callback, which invalidated not
only the second gesture that we wanted to ignore, but also the first one
that was correct and should be still handled.
The behavior on Android is unfortunately not perfect, because when we
start touching a second item, the gesture on the first one gets
invalidated as the `onTouchesUp` callback is not properly called on the
gesture instance. This is a `react-native-gesture-handler` issue that I
reported here:
software-mansion/react-native-gesture-handler#35431 parent 1601090 commit 6427c8d
2 files changed
Lines changed: 33 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
Lines changed: 32 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
456 | 456 | | |
457 | 457 | | |
458 | 458 | | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
459 | 464 | | |
460 | 465 | | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | 466 | | |
467 | | - | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
468 | 471 | | |
469 | 472 | | |
470 | 473 | | |
471 | 474 | | |
472 | 475 | | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
484 | | - | |
485 | | - | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
490 | 484 | | |
491 | 485 | | |
492 | 486 | | |
493 | 487 | | |
494 | | - | |
495 | 488 | | |
496 | 489 | | |
497 | 490 | | |
498 | 491 | | |
499 | | - | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
500 | 507 | | |
501 | 508 | | |
502 | 509 | | |
| |||
0 commit comments