Commit 8973115
authored
fix: Item position drift on slow web container resize (#562)
## Description
On web, slowly resizing a Sortable container (e.g. dragging the docs
split-pane divider) left grid items with wrong sizes/positions.
Cause: `useItemLayout` only applied a new position when it differed by
1px+ from the previous reaction input, but that baseline advances on
every run even when the update is skipped - so a slow resize's sub-pixel
steps were skipped forever and positions drifted out of sync with the
CSS-driven sizes.
Fix: compare against the current position instead, and snap to the exact
target on the non-animated path.
## Changes showcase
Repro: Grid > Examples > Touchable, widen so the split shows, drag the
divider slowly. Items now stay aligned (before: stale positions while
shrinking).1 parent e9b81e3 commit 8973115
1 file changed
Lines changed: 16 additions & 17 deletions
File tree
Lines changed: 16 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
177 | | - | |
| 176 | + | |
| 177 | + | |
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | 187 | | |
192 | 188 | | |
193 | 189 | | |
194 | 190 | | |
195 | 191 | | |
196 | 192 | | |
197 | | - | |
| 193 | + | |
198 | 194 | | |
199 | 195 | | |
200 | 196 | | |
201 | 197 | | |
202 | 198 | | |
203 | 199 | | |
204 | | - | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
205 | 203 | | |
206 | 204 | | |
207 | 205 | | |
| |||
220 | 218 | | |
221 | 219 | | |
222 | 220 | | |
223 | | - | |
| 221 | + | |
224 | 222 | | |
225 | 223 | | |
226 | 224 | | |
227 | 225 | | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | 226 | | |
233 | 227 | | |
234 | 228 | | |
235 | 229 | | |
236 | | - | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
237 | 236 | | |
238 | | - | |
| 237 | + | |
239 | 238 | | |
240 | 239 | | |
241 | 240 | | |
| |||
0 commit comments