fix: Respect Sortable.Flex alignItems before items are measured#560
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
MatiPl01
force-pushed
the
fix/flex-align-items
branch
from
df57488 to
95ff517
Compare
MatiPl01
changed the title
MatiPl01
force-pushed
the
fix/flex-align-items
branch
from
95ff517 to
073b7e0
Compare
Sortable.Flex put `alignSelf: 'flex-start'` on every item to stop them stretching (stretched items would be measured at the wrong size, which breaks the absolute layout). But `alignSelf` overrides the container's `alignItems`, so a user-provided `alignItems` (e.g. 'center') was ignored until the component switched to its absolute layout after measuring, causing a visible jump with differently-sized items. Prevent stretching on the container instead: fall back to `alignItems: 'flex-start'` when no `alignItems` is set (the default that would stretch), and drop the per-item `alignSelf` override. Any provided `alignItems` now applies from the first render.
MatiPl01
force-pushed
the
fix/flex-align-items
branch
from
073b7e0 to
ae315a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix self alignment default value in flex.