fix: actually allow vault to export all secrets by default

Author: aryanjassal

src/secrets/CommandEnv.ts

@@ -27,10 +27,10 @@ class CommandEnv extends CommandPolykey {
       'command and arguments formatted as [envPaths...][-- cmd [cmdArgs...]]',
       binParsers.parseEnvArgs,
     );
-    this.passThroughOptions();
+    this.passThroughOptions(); // Let -- pass through as-is to parse as delimiter for cmd
     this.action(
       async (
-        args: [Array<[string, string, string?]>, Array<string>],
+        args: [Array<[string, string?, string?]>, Array<string>],
         options,
       ) => {
         args[1].shift();
@@ -93,10 +93,10 @@ class CommandEnv extends CommandPolykey {
               let first = true;
               for (const envVariable of envVariables) {
                 const [nameOrId, secretName, secretNameNew] = envVariable;
-                secretRenameMap.set(secretName, secretNameNew);
+                secretRenameMap.set(secretName ?? '/', secretNameNew);
                 await writer.write({
-                  nameOrId,
-                  secretName,
+                  nameOrId: nameOrId,
+                  secretName: secretName ?? '/',
                   metadata: first ? auth : undefined,
                 });
                 first = false;

src/utils/parsers.ts

@@ -124,13 +124,13 @@ function parseSecretPathValue(secretPath: string): [string, string, string?] {
   return [vaultName, directoryPath, value];
 }
 
-function parseSecretPathEnv(secretPath: string): [string, string, string?] {
+function parseSecretPathEnv(secretPath: string): [string, string?, string?] {
   // The colon character `:` is prohibited in vaultName, so it's first occurence
   // means that this is the delimiter between vaultName and secretPath.
   const colonIndex = secretPath.indexOf(':');
   // If no colon exists, treat entire string as vault name
   if (colonIndex === -1) {
-    return [parseVaultName(secretPath), '', undefined];
+    return [parseVaultName(secretPath), undefined, undefined];
   }
   // Calculate contents before the `=` separator
   const vaultNamePart = secretPath.substring(0, colonIndex);
@@ -229,9 +229,9 @@ const parseSeedNodes: (data: string) => [SeedNodes, boolean] =
  */
 function parseEnvArgs(
   value: string,
-  prev: [Array<[string, string, string?]>, Array<string>] | undefined,
-): [Array<[string, string, string?]>, Array<string>] {
-  const current: [Array<[string, string, string?]>, Array<string>] = prev ?? [
+  prev: [Array<[string, string?, string?]>, Array<string>] | undefined,
+): [Array<[string, string?, string?]>, Array<string>] {
+  const current: [Array<[string, string?, string?]>, Array<string>] = prev ?? [
     [],
     [],
   ];