chore: updated tests to be more accurate

[ci skip]

Author: aryanjassal

src/errors.ts

@@ -152,6 +152,11 @@ class ErrorPolykeyCLIDuplicateEnvName<T> extends ErrorPolykeyCLI<T> {
   exitCode = sysexits.USAGE;
 }
 
+class ErrorPolykeyCLIMakeDirectory<T> extends ErrorPolykeyCLI<T> {
+  static description = 'Failed to create one or more directories';
+  exitCode = 1;
+}
+
 export {
   ErrorPolykeyCLI,
   ErrorPolykeyCLIUncaughtException,
@@ -172,4 +177,5 @@ export {
   ErrorPolykeyCLINodePingFailed,
   ErrorPolykeyCLIInvalidEnvName,
   ErrorPolykeyCLIDuplicateEnvName,
+  ErrorPolykeyCLIMakeDirectory,
 };

src/secrets/CommandMkdir.ts

@@ -4,8 +4,10 @@ import * as binUtils from '../utils';
 import * as binOptions from '../utils/options';
 import * as binParsers from '../utils/parsers';
 import * as binProcessors from '../utils/processors';
-import { ErrorPolykeyCLIUncaughtException } from '@/errors';
-import { utils } from '@';
+import {
+  ErrorPolykeyCLIMakeDirectory,
+  ErrorPolykeyCLIUncaughtException,
+} from '@/errors';
 
 class CommandMkdir extends CommandPolykey {
   constructor(...args: ConstructorParameters<typeof CommandPolykey>) {
@@ -78,9 +80,10 @@ class CommandMkdir extends CommandPolykey {
           'WARNING: Empty directories will not be affected by modifications to the vault state (version change, sharing/cloning, etc.)\n',
         );
 
+        let shouldError = false;
         for await (const result of response.readable) {
           if (result.type === 'error') {
-            process.exitCode = 1;
+            shouldError = true;
             let message: string = '';
             switch (result.code) {
               case 'ENOENT':
@@ -99,6 +102,11 @@ class CommandMkdir extends CommandPolykey {
             );
           }
         }
+        if (shouldError) {
+          throw new ErrorPolykeyCLIMakeDirectory(
+            'Failed to create one or more directories',
+          );
+        }
       } finally {
         if (pkClient! != null) await pkClient.stop();
       }

tests/secrets/mkdir.test.ts

@@ -67,7 +67,7 @@ describe('commandMkdir', () => {
     const vaultName = 'vault' as VaultName;
     const dirName1 = 'dir1';
     const dirName2 = 'dir2';
-    const dirNameNested = `${dirName1}/${dirName2}`;
+    const dirNameNested = path.join(dirName1, dirName2);
     const vaultId = await polykeyAgent.vaultManager.createVault(vaultName);
     command = [
       'secrets',
@@ -93,7 +93,7 @@ describe('commandMkdir', () => {
     const vaultName = 'vault' as VaultName;
     const dirName1 = 'dir1';
     const dirName2 = 'dir2';
-    const dirNameNested = `${dirName1}/${dirName2}`;
+    const dirNameNested = path.join(dirName1, dirName2);
     const vaultId = await polykeyAgent.vaultManager.createVault(vaultName);
     command = [
       'secrets',