Skip to content

Commit 5be841a

Browse files
tegefaulkestegefaulkes
committed
syntax: fixes to test names
[ci skip]
1 parent ab4aec0 commit 5be841a

9 files changed

Lines changed: 27 additions & 25 deletions

File tree

‎src/rpc/RPCClient.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ class RPCClient<M extends ClientManifest> {
206206
// Clean up if any problems, ignore errors if already closed
207207
await callerInterface.readable.cancel(e);
208208
throw e;
209+
209210
}
210211
return callerInterface.readable;
211212
}

‎src/rpc/RPCServer.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ class RPCServer extends EventTarget {
123123
logger,
124124
}: {
125125
manifest: ServerManifest;
126+
126127
middlewareFactory: MiddlewareFactory<
127128
JSONRPCRequest,
128129
Uint8Array,
@@ -157,7 +158,7 @@ class RPCServer extends EventTarget {
157158
key,
158159
manifestItem.handle.bind(manifestItem),
159160
manifestItem.timeout,
160-
);
161+
);
161162
continue;
162163
}
163164
if (manifestItem instanceof ClientHandler) {

‎tests/client/handlers/agentLockAll.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ describe('agentLockAll', () => {
7070
recursive: true,
7171
});
7272
});
73-
test('Locks all current sessions', async () => {
73+
test('locks all current sessions', async () => {
7474
// Setup
7575
const rpcServer = await RPCServer.createRPCServer({
7676
manifest: {

‎tests/client/handlers/agentStop.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ describe('agentStop', () => {
8080
recursive: true,
8181
});
8282
});
83-
test('Stops the agent', async () => {
83+
test('stops the agent', async () => {
8484
// Setup
8585
const rpcServer = await RPCServer.createRPCServer({
8686
manifest: {

‎tests/client/handlers/gestaltsGestaltGetByIdentity.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ describe('gestaltsGestaltGetByIdentity', () => {
9090
recursive: true,
9191
});
9292
});
93-
test('getys gestalt by identity', async () => {
93+
test('gets gestalt by identity', async () => {
9494
// Setup
9595
const rpcServer = await RPCServer.createRPCServer({
9696
manifest: {

‎tests/client/timeoutMiddleware.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('timeoutMiddleware', () => {
7979
recursive: true,
8080
});
8181
});
82-
test('Server side timeout updates', async () => {
82+
test('server side timeout updates', async () => {
8383
// Setup
8484
const ctxProm = promise<ContextTimed>();
8585
class EchoHandler extends UnaryHandler<

‎tests/rpc/RPC.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ describe('RPC', () => {
355355
await rpcClient.destroy();
356356
},
357357
);
358-
test('Middleware can end stream early', async () => {
358+
test('middleware can end stream early', async () => {
359359
const { clientPair, serverPair } = rpcTestUtils.createTapPairs<
360360
Uint8Array,
361361
Uint8Array

‎tests/rpc/RPCServer.test.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ describe(`${RPCServer.name}`, () => {
217217
},
218218
);
219219
testProp(
220-
'Handler is provided with container',
220+
'handler is provided with container',
221221
[specificMessageArb],
222222
async (messages) => {
223223
const stream = rpcTestUtils.messagesToReadableStream(messages);
@@ -254,7 +254,7 @@ describe(`${RPCServer.name}`, () => {
254254
},
255255
);
256256
testProp(
257-
'Handler is provided with connectionInfo',
257+
'handler is provided with connectionInfo',
258258
[specificMessageArb],
259259
async (messages) => {
260260
const stream = rpcTestUtils.messagesToReadableStream(messages);
@@ -295,7 +295,7 @@ describe(`${RPCServer.name}`, () => {
295295
expect(handledConnectionInfo).toBe(connectionInfo);
296296
},
297297
);
298-
testProp('Handler can be aborted', [specificMessageArb], async (messages) => {
298+
testProp('handler can be aborted', [specificMessageArb], async (messages) => {
299299
const stream = rpcTestUtils.messagesToReadableStream(messages);
300300
class TestMethod extends DuplexHandler {
301301
public async *handle(
@@ -346,7 +346,7 @@ describe(`${RPCServer.name}`, () => {
346346
).not.toThrow();
347347
await rpcServer.destroy();
348348
});
349-
testProp('Handler yields nothing', [specificMessageArb], async (messages) => {
349+
testProp('handler yields nothing', [specificMessageArb], async (messages) => {
350350
const stream = rpcTestUtils.messagesToReadableStream(messages);
351351
class TestMethod extends DuplexHandler {
352352
public async *handle(
@@ -743,7 +743,7 @@ describe(`${RPCServer.name}`, () => {
743743
await rpcServer.destroy();
744744
},
745745
);
746-
test('default timeout', async () => {
746+
test('timeout with default time after handler selected', async () => {
747747
const ctxProm = promise<ContextTimed>();
748748
class TestHandler extends RawHandler {
749749
public handle(_input, _connectionInfo, ctx_): ReadableStream<Uint8Array> {
@@ -793,7 +793,7 @@ describe(`${RPCServer.name}`, () => {
793793
await expect(outputResult).toReject();
794794
await rpcServer.destroy();
795795
});
796-
test('default timeout before handler selected', async () => {
796+
test('timeout with default time before handler selected', async () => {
797797
const rpcServer = await RPCServer.createRPCServer({
798798
manifest: {},
799799
streamKeepAliveTimeoutTime: 100,
@@ -1037,7 +1037,7 @@ describe(`${RPCServer.name}`, () => {
10371037
await rpcServer.destroy();
10381038
});
10391039
testProp(
1040-
'Middleware can update timeout timer',
1040+
'middleware can update timeout timer',
10411041
[specificMessageArb],
10421042
async (messages) => {
10431043
const stream = rpcTestUtils.messagesToReadableStream(messages);

‎tests/websockets/WebSocket.test.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ describe('WebSocket', () => {
150150
expect((await reader.read()).done).toBeTrue();
151151
logger.info('ending');
152152
});
153-
test('Handles a connection and closes before message', async () => {
153+
test('handles a connection and closes before message', async () => {
154154
webSocketServer = await WebSocketServer.createWebSocketServer({
155155
connectionCallback: (streamPair) => {
156156
logger.info('inside callback');
@@ -178,7 +178,7 @@ describe('WebSocket', () => {
178178
logger.info('ending');
179179
});
180180
testProp(
181-
'Handles multiple connections',
181+
'handles multiple connections',
182182
[streamsArb],
183183
async (streamsData) => {
184184
try {
@@ -297,7 +297,7 @@ describe('WebSocket', () => {
297297
});
298298
// Readable backpressure is not actually supported. We're dealing with it by
299299
// using a buffer with a provided limit that can be very large.
300-
test('Exceeding readable buffer limit causes error', async () => {
300+
test('exceeding readable buffer limit causes error', async () => {
301301
const startReading = promise<void>();
302302
const handlingProm = promise<void>();
303303
webSocketServer = await WebSocketServer.createWebSocketServer({
@@ -409,7 +409,7 @@ describe('WebSocket', () => {
409409
await expect(serverWritable.write(Buffer.from('test'))).rejects.toThrow();
410410
logger.info('ending');
411411
});
412-
test('Server ends connection abruptly', async () => {
412+
test('server ends connection abruptly', async () => {
413413
const testProcess = await testsUtils.spawn(
414414
'ts-node',
415415
[
@@ -578,7 +578,7 @@ describe('WebSocket', () => {
578578
}
579579
},
580580
);
581-
test('Destroying ClientServer stops all connections', async () => {
581+
test('destroying ClientServer stops all connections', async () => {
582582
const streamPairProm =
583583
promise<ReadableWritablePair<Uint8Array, Uint8Array>>();
584584
webSocketServer = await WebSocketServer.createWebSocketServer({
@@ -618,7 +618,7 @@ describe('WebSocket', () => {
618618
await expect(serverWritable.write(Buffer.from('test'))).rejects.toThrow();
619619
logger.info('ending');
620620
});
621-
test('Server rejects normal HTTPS requests', async () => {
621+
test('server rejects normal HTTPS requests', async () => {
622622
webSocketServer = await WebSocketServer.createWebSocketServer({
623623
connectionCallback: (streamPair) => {
624624
logger.info('inside callback');
@@ -676,7 +676,7 @@ describe('WebSocket', () => {
676676
});
677677
});
678678
describe('WebSocketClient', () => {
679-
test('Destroying ClientClient stops all connections', async () => {
679+
test('destroying ClientClient stops all connections', async () => {
680680
const streamPairProm =
681681
promise<ReadableWritablePair<Uint8Array, Uint8Array>>();
682682
webSocketServer = await WebSocketServer.createWebSocketServer({
@@ -718,7 +718,7 @@ describe('WebSocket', () => {
718718
await webSocketServer.stop();
719719
logger.info('ending');
720720
});
721-
test('Authentication rejects bad server certificate', async () => {
721+
test('authentication rejects bad server certificate', async () => {
722722
const invalidNodeId = testNodeUtils.generateRandomNodeId();
723723
webSocketServer = await WebSocketServer.createWebSocketServer({
724724
connectionCallback: (streamPair) => {
@@ -749,7 +749,7 @@ describe('WebSocket', () => {
749749
await webSocketServer.stop();
750750
logger.info('ending');
751751
});
752-
test('Authenticates with multiple certs in chain', async () => {
752+
test('authenticates with multiple certs in chain', async () => {
753753
const keyPairs: Array<KeyPair> = [
754754
keyRing.keyPair,
755755
keysUtils.generateKeyPair(),
@@ -787,7 +787,7 @@ describe('WebSocket', () => {
787787
expect(activeConnections.size).toBe(1);
788788
logger.info('ending');
789789
});
790-
test('Authenticates with multiple expected nodes', async () => {
790+
test('authenticates with multiple expected nodes', async () => {
791791
const alternativeNodeId = testNodeUtils.generateRandomNodeId();
792792
webSocketServer = await WebSocketServer.createWebSocketServer({
793793
connectionCallback: (streamPair) => {
@@ -815,7 +815,7 @@ describe('WebSocket', () => {
815815
expect(activeConnections.size).toBe(1);
816816
logger.info('ending');
817817
});
818-
test('Connection times out', async () => {
818+
test('connection times out', async () => {
819819
webSocketClient = await WebSocketClient.createWebSocketClient({
820820
host,
821821
port: 12345,
@@ -854,7 +854,7 @@ describe('WebSocket', () => {
854854
await webSocketClient.destroy();
855855
logger.info('ending');
856856
});
857-
test('Stream is aborted', async () => {
857+
test('stream is aborted', async () => {
858858
webSocketServer = await WebSocketServer.createWebSocketServer({
859859
connectionCallback: (streamPair) => {
860860
logger.info('inside callback');

0 commit comments

Comments
 (0)