wip: NodeConnectionManager lifecycle tests

[ci skip]

Author: tegefaulkes

src/nodes/NodeConnectionManager.ts

@@ -4,7 +4,6 @@ import type { ContextTimed } from '@matrixai/contexts';
 import type KeyRing from '../keys/KeyRing';
 import type { Host, Hostname, Port } from '../network/types';
 import type NodeGraph from './NodeGraph';
-import type TaskManager from '../tasks/TaskManager';
 import type {
   NodeAddress,
   NodeData,
@@ -69,7 +68,6 @@ class NodeConnectionManager {
   protected logger: Logger;
   protected nodeGraph: NodeGraph;
   protected keyRing: KeyRing;
-  protected taskManager: TaskManager;
   protected quicSocket: QUICSocket;
   // NodeManager has to be passed in during start to allow co-dependency
   protected nodeManager: NodeManager | undefined;
@@ -98,7 +96,6 @@ class NodeConnectionManager {
   public constructor({
     keyRing,
     nodeGraph,
-    taskManager,
     quicSocket,
     quicClientConfig,
     seedNodes = {},
@@ -110,7 +107,6 @@ class NodeConnectionManager {
   }: {
     nodeGraph: NodeGraph;
     keyRing: KeyRing;
-    taskManager: TaskManager;
     quicSocket: QUICSocket;
     quicClientConfig: QUICClientConfig;
     seedNodes?: SeedNodes;
@@ -123,7 +119,6 @@ class NodeConnectionManager {
     this.logger = logger ?? new Logger(NodeConnectionManager.name);
     this.keyRing = keyRing;
     this.nodeGraph = nodeGraph;
-    this.taskManager = taskManager;
     this.quicSocket = quicSocket;
     this.quicClientConfig = quicClientConfig;
     const localNodeIdEncoded = nodesUtils.encodeNodeId(keyRing.getNodeId());
@@ -154,12 +149,17 @@ class NodeConnectionManager {
   public async stop() {
     this.logger.info(`Stopping ${this.constructor.name}`);
     this.nodeManager = undefined;
+    const destroyProms: Array<Promise<void>> = [];
     for (const [nodeId, connAndLock] of this.connections) {
       if (connAndLock == null) continue;
       if (connAndLock.connection == null) continue;
       // It exists so we want to destroy it
-      await this.destroyConnection(IdInternal.fromString<NodeId>(nodeId));
+      const destroyProm = this.destroyConnection(
+        IdInternal.fromString<NodeId>(nodeId),
+      );
+      destroyProms.push(destroyProm);
     }
+    await Promise.all(destroyProms);
     this.logger.info(`Stopped ${this.constructor.name}`);
   }
 

tests/nodes/NodeConnection.test.ts

@@ -55,7 +55,7 @@ async function verify(key: ArrayBuffer, data: ArrayBuffer, sig: ArrayBuffer) {
   return webcrypto.subtle.verify('HMAC', cryptoKey, sig, data);
 }
 
-describe('${NodeConnection.name}', () => {
+describe(`${NodeConnection.name}`, () => {
   const logger = new Logger(`${NodeConnection.name} test`, LogLevel.WARN, [
     new StreamHandler(
       formatting.format`${formatting.level}:${formatting.keys}:${formatting.msg}`,