Skip to content

Commit ab4aec0

Browse files
committed
syntax: fixed middleware utils imports
[ci skip]
1 parent 03c56f9 commit ab4aec0

11 files changed

Lines changed: 85 additions & 75 deletions

src/PolykeyAgent.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import { DB } from '@matrixai/db';
1212
import { CreateDestroyStartStop } from '@matrixai/async-init/dist/CreateDestroyStartStop';
1313
import RPCServer from './rpc/RPCServer';
1414
import WebSocketServer from './websockets/WebSocketServer';
15-
import * as rpcMiddlewareUtils from './rpc/utils/middleware';
16-
import * as clientMiddleware from './client/utils/middleware';
15+
import * as rpcUtilsMiddleware from './rpc/utils/middleware';
16+
import * as clientUtilsMiddleware from './client/utils/middleware';
1717
import { WorkerManager } from './workers';
1818
import * as networkUtils from './network/utils';
1919
import KeyRing from './keys/KeyRing';
@@ -437,8 +437,8 @@ class PolykeyAgent {
437437
sessionManager: sessionManager,
438438
vaultManager: vaultManager,
439439
}),
440-
middlewareFactory: rpcMiddlewareUtils.defaultServerMiddlewareWrapper(
441-
clientMiddleware.middlewareServer(sessionManager, keyRing),
440+
middlewareFactory: rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
441+
clientUtilsMiddleware.middlewareServer(sessionManager, keyRing),
442442
),
443443
sensitive: false,
444444
logger: logger.getChild('RPCServerClient'),

src/PolykeyClient.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import path from 'path';
44
import Logger from '@matrixai/logger';
55
import { CreateDestroyStartStop } from '@matrixai/async-init/dist/CreateDestroyStartStop';
66
import RPCClient from './rpc/RPCClient';
7-
import * as rpcMiddlewareUtils from './rpc/utils/middleware';
8-
import * as clientMiddleware from './client/utils/middleware';
7+
import * as rpcUtilsMiddleware from './rpc/utils/middleware';
8+
import * as clientUtilsMiddleware from './client/utils/middleware';
99
import { Session } from './sessions';
1010
import * as errors from './errors';
1111
import * as utils from './utils';
@@ -61,8 +61,8 @@ class PolykeyClient<M extends ClientManifest> {
6161
manifest,
6262
streamFactory,
6363
middlewareFactory:
64-
rpcMiddlewareUtils.defaultClientMiddlewareWrapper(
65-
clientMiddleware.middlewareClient(session),
64+
rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
65+
clientUtilsMiddleware.middlewareClient(session),
6666
),
6767
logger: logger.getChild(RPCClient.name),
6868
});

src/rpc/RPCClient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import { CreateDestroy, ready } from '@matrixai/async-init/dist/CreateDestroy';
2323
import Logger from '@matrixai/logger';
2424
import { IdInternal } from '@matrixai/id';
2525
import { Timer } from '@matrixai/timer';
26-
import * as middlewareUtils from './utils/middleware';
26+
import * as rpcUtilsMiddleware from './utils/middleware';
2727
import * as rpcErrors from './errors';
2828
import * as rpcUtils from './utils/utils';
2929
import { never, promise } from '../utils';
@@ -50,7 +50,7 @@ class RPCClient<M extends ClientManifest> {
5050
static async createRPCClient<M extends ClientManifest>({
5151
manifest,
5252
streamFactory,
53-
middlewareFactory = middlewareUtils.defaultClientMiddlewareWrapper(),
53+
middlewareFactory = rpcUtilsMiddleware.defaultClientMiddlewareWrapper(),
5454
streamKeepAliveTimeoutTime = 60_000, // 1 minute
5555
logger = new Logger(this.name),
5656
}: {

src/rpc/RPCServer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
import * as rpcEvents from './events';
3131
import * as rpcUtils from './utils/utils';
3232
import * as rpcErrors from './errors';
33-
import * as middlewareUtils from './utils/middleware';
33+
import * as rpcUtilsMiddleware from './utils/middleware';
3434
import { never } from '../utils/utils';
3535
import { sysexits } from '../errors';
3636

@@ -69,7 +69,7 @@ class RPCServer extends EventTarget {
6969
*/
7070
public static async createRPCServer({
7171
manifest,
72-
middlewareFactory = middlewareUtils.defaultServerMiddlewareWrapper(),
72+
middlewareFactory = rpcUtilsMiddleware.defaultServerMiddlewareWrapper(),
7373
sensitive = false,
7474
streamKeepAliveTimeoutTime = 60_000, // 1 minute
7575
timeoutForceCloseTime = 2_000, // 2 seconds
@@ -435,7 +435,7 @@ class RPCServer extends EventTarget {
435435
});
436436

437437
const prom = (async () => {
438-
const headTransformStream = middlewareUtils.binaryToJsonMessageStream(
438+
const headTransformStream = rpcUtilsMiddleware.binaryToJsonMessageStream(
439439
rpcUtils.parseJSONRPCRequest,
440440
);
441441
// Transparent transform used as a point to cancel the input stream from

tests/client/authenticationMiddleware.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import * as clientRPCUtils from '@/client/utils';
1919
import * as authMiddleware from '@/client/utils/authenticationMiddleware';
2020
import { UnaryCaller } from '@/rpc/callers';
2121
import { UnaryHandler } from '@/rpc/handlers';
22-
import * as middlewareUtils from '@/rpc/utils/middleware';
22+
import * as rpcUtilsMiddleware from '@/rpc/utils/middleware';
2323
import WebSocketServer from '@/websockets/WebSocketServer';
2424
import WebSocketClient from '@/websockets/WebSocketClient';
2525
import * as testsUtils from '../utils';
@@ -107,7 +107,7 @@ describe('authenticationMiddleware', () => {
107107
manifest: {
108108
testHandler: new EchoHandler({ logger }),
109109
},
110-
middlewareFactory: middlewareUtils.defaultServerMiddlewareWrapper(
110+
middlewareFactory: rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
111111
authMiddleware.authenticationMiddlewareServer(sessionManager, keyRing),
112112
),
113113
logger,
@@ -134,7 +134,7 @@ describe('authenticationMiddleware', () => {
134134
>(),
135135
},
136136
streamFactory: async () => clientClient.startConnection(),
137-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
137+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
138138
authMiddleware.authenticationMiddlewareClient(session),
139139
),
140140
logger,

tests/client/handlers/agentUnlock.test.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import { AgentUnlockHandler } from '@/client/handlers/agentUnlock';
1313
import RPCClient from '@/rpc/RPCClient';
1414
import { Session, SessionManager } from '@/sessions';
1515
import * as clientUtils from '@/client/utils';
16-
import * as authMiddleware from '@/client/utils/authenticationMiddleware';
17-
import * as middlewareUtils from '@/rpc/utils/middleware';
16+
import * as clientUtilsAuthMiddleware from '@/client/utils/authenticationMiddleware';
17+
import * as rpcUtilsMiddleware from '@/rpc/utils/middleware';
1818
import WebSocketServer from '@/websockets/WebSocketServer';
1919
import WebSocketClient from '@/websockets/WebSocketClient';
2020
import { agentUnlock } from '@/client';
@@ -92,8 +92,11 @@ describe('agentUnlock', () => {
9292
manifest: {
9393
agentUnlock: new AgentUnlockHandler({}),
9494
},
95-
middlewareFactory: middlewareUtils.defaultServerMiddlewareWrapper(
96-
authMiddleware.authenticationMiddlewareServer(sessionManager, keyRing),
95+
middlewareFactory: rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
96+
clientUtilsAuthMiddleware.authenticationMiddlewareServer(
97+
sessionManager,
98+
keyRing,
99+
),
97100
),
98101
logger,
99102
});
@@ -115,8 +118,8 @@ describe('agentUnlock', () => {
115118
agentUnlock,
116119
},
117120
streamFactory: async () => clientClient.startConnection(),
118-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
119-
authMiddleware.authenticationMiddlewareClient(session),
121+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
122+
clientUtilsAuthMiddleware.authenticationMiddlewareClient(session),
120123
),
121124
logger,
122125
});

tests/client/timeoutMiddleware.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import RPCClient from '@/rpc/RPCClient';
1919
import * as timeoutMiddleware from '@/client/utils/timeoutMiddleware';
2020
import { UnaryCaller } from '@/rpc/callers';
2121
import { UnaryHandler } from '@/rpc/handlers';
22-
import * as middlewareUtils from '@/rpc/utils/middleware';
22+
import * as rpcUtilsMiddleware from '@/rpc/utils/middleware';
2323
import WebSocketServer from '@/websockets/WebSocketServer';
2424
import WebSocketClient from '@/websockets/WebSocketClient';
2525
import { promise } from '@/utils';
@@ -100,7 +100,7 @@ describe('timeoutMiddleware', () => {
100100
manifest: {
101101
testHandler: new EchoHandler({ logger }),
102102
},
103-
middlewareFactory: middlewareUtils.defaultServerMiddlewareWrapper(
103+
middlewareFactory: rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
104104
timeoutMiddleware.timeoutMiddlewareServer,
105105
),
106106
logger,
@@ -127,7 +127,7 @@ describe('timeoutMiddleware', () => {
127127
>(),
128128
},
129129
streamFactory: async () => clientClient.startConnection(),
130-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
130+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
131131
timeoutMiddleware.timeoutMiddlewareClient,
132132
),
133133
logger,
@@ -160,7 +160,7 @@ describe('timeoutMiddleware', () => {
160160
manifest: {
161161
testHandler: new EchoHandler({ logger }),
162162
},
163-
middlewareFactory: middlewareUtils.defaultServerMiddlewareWrapper(
163+
middlewareFactory: rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
164164
timeoutMiddleware.timeoutMiddlewareServer,
165165
),
166166
streamKeepAliveTimeoutTime: 100,
@@ -188,7 +188,7 @@ describe('timeoutMiddleware', () => {
188188
>(),
189189
},
190190
streamFactory: async () => clientClient.startConnection(),
191-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
191+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
192192
timeoutMiddleware.timeoutMiddlewareClient,
193193
),
194194
logger,

tests/rpc/RPC.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
UnaryCaller,
2424
} from '@/rpc/callers';
2525
import * as rpcErrors from '@/rpc/errors';
26-
import * as rpcMiddlewareUtils from '@/rpc/utils/middleware';
26+
import * as rpcUtilsMiddleware from '@/rpc/utils/middleware';
2727
import * as rpcTestUtils from './utils';
2828

2929
describe('RPC', () => {
@@ -367,7 +367,7 @@ describe('RPC', () => {
367367
yield* input;
368368
}
369369
}
370-
const middleware = rpcMiddlewareUtils.defaultServerMiddlewareWrapper(() => {
370+
const middleware = rpcUtilsMiddleware.defaultServerMiddlewareWrapper(() => {
371371
return {
372372
forward: new TransformStream({
373373
start: (controller) => {

tests/rpc/RPCClient.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {
2020
ServerCaller,
2121
UnaryCaller,
2222
} from '@/rpc/callers';
23-
import * as middlewareUtils from '@/rpc/utils/middleware';
23+
import * as rpcUtilsMiddleware from '@/rpc/utils/middleware';
2424
import { promise, sleep } from '@/utils/index';
2525
import * as rpcTestUtils from './utils';
2626

@@ -364,7 +364,7 @@ describe(`${RPCClient.name}`, () => {
364364
const rpcClient = await RPCClient.createRPCClient({
365365
manifest: {},
366366
streamFactory: async () => streamPair,
367-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
367+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
368368
() => {
369369
return {
370370
forward: new TransformStream<JSONRPCRequest, JSONRPCRequest>({
@@ -430,7 +430,7 @@ describe(`${RPCClient.name}`, () => {
430430
const rpcClient = await RPCClient.createRPCClient({
431431
manifest: {},
432432
streamFactory: async () => streamPair,
433-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
433+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
434434
() => {
435435
return {
436436
forward: new TransformStream(),
@@ -1111,7 +1111,7 @@ describe(`${RPCClient.name}`, () => {
11111111
ctxProm.resolveP(ctx);
11121112
return streamPair;
11131113
},
1114-
middlewareFactory: middlewareUtils.defaultClientMiddlewareWrapper(
1114+
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(
11151115
(ctx) => {
11161116
ctx.timer.reset(1000);
11171117
return {

tests/rpc/RPCServer.test.ts

Lines changed: 38 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
ServerHandler,
2424
UnaryHandler,
2525
} from '@/rpc/handlers';
26-
import * as middlewareUtils from '@/rpc/utils/middleware';
26+
import * as rpcUtilsMiddleware from '@/rpc/utils/middleware';
2727
import { promise, sleep } from '@/utils';
2828
import * as rpcTestUtils from './utils';
2929

@@ -583,7 +583,7 @@ describe(`${RPCServer.name}`, () => {
583583
yield* input;
584584
}
585585
}
586-
const middlewareFactory = middlewareUtils.defaultServerMiddlewareWrapper(
586+
const middlewareFactory = rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
587587
() => {
588588
return {
589589
forward: new TransformStream({
@@ -630,7 +630,7 @@ describe(`${RPCServer.name}`, () => {
630630
yield* input;
631631
}
632632
}
633-
const middleware = middlewareUtils.defaultServerMiddlewareWrapper(() => {
633+
const middleware = rpcUtilsMiddleware.defaultServerMiddlewareWrapper(() => {
634634
return {
635635
forward: new TransformStream(),
636636
reverse: new TransformStream({
@@ -678,36 +678,38 @@ describe(`${RPCServer.name}`, () => {
678678
yield* input;
679679
}
680680
}
681-
const middleware = middlewareUtils.defaultServerMiddlewareWrapper(() => {
682-
let first = true;
683-
let reverseController: TransformStreamDefaultController<JSONRPCResponse>;
684-
return {
685-
forward: new TransformStream<
686-
JSONRPCRequest<TestType>,
687-
JSONRPCRequest<TestType>
688-
>({
689-
transform: (chunk, controller) => {
690-
if (first && chunk.params?.metadata.token !== validToken) {
691-
reverseController.enqueue(failureMessage);
692-
// Closing streams early
693-
controller.terminate();
694-
reverseController.terminate();
695-
}
696-
first = false;
697-
controller.enqueue(chunk);
698-
},
699-
}),
700-
reverse: new TransformStream({
701-
start: (controller) => {
702-
// Kidnapping reverse controller
703-
reverseController = controller;
704-
},
705-
transform: (chunk, controller) => {
706-
controller.enqueue(chunk);
707-
},
708-
}),
709-
};
710-
});
681+
const middleware = rpcUtilsMiddleware.defaultServerMiddlewareWrapper(
682+
() => {
683+
let first = true;
684+
let reverseController: TransformStreamDefaultController<JSONRPCResponse>;
685+
return {
686+
forward: new TransformStream<
687+
JSONRPCRequest<TestType>,
688+
JSONRPCRequest<TestType>
689+
>({
690+
transform: (chunk, controller) => {
691+
if (first && chunk.params?.metadata.token !== validToken) {
692+
reverseController.enqueue(failureMessage);
693+
// Closing streams early
694+
controller.terminate();
695+
reverseController.terminate();
696+
}
697+
first = false;
698+
controller.enqueue(chunk);
699+
},
700+
}),
701+
reverse: new TransformStream({
702+
start: (controller) => {
703+
// Kidnapping reverse controller
704+
reverseController = controller;
705+
},
706+
transform: (chunk, controller) => {
707+
controller.enqueue(chunk);
708+
},
709+
}),
710+
};
711+
},
712+
);
711713
const rpcServer = await RPCServer.createRPCServer({
712714
manifest: {
713715
testMethod: new TestMethod({}),
@@ -1050,15 +1052,14 @@ describe(`${RPCServer.name}`, () => {
10501052
yield* input;
10511053
}
10521054
}
1053-
const middlewareFactory = middlewareUtils.defaultServerMiddlewareWrapper(
1054-
(ctx) => {
1055+
const middlewareFactory =
1056+
rpcUtilsMiddleware.defaultServerMiddlewareWrapper((ctx) => {
10551057
ctx.timer.reset(12345);
10561058
return {
10571059
forward: new TransformStream(),
10581060
reverse: new TransformStream(),
10591061
};
1060-
},
1061-
);
1062+
});
10621063
const rpcServer = await RPCServer.createRPCServer({
10631064
manifest: {
10641065
testMethod: new TestMethod({}),

0 commit comments

Comments
 (0)