refactor: account chart cleanup

[graphieros]

Just minor refactoring to keep things clean.
Should've done that yesterday, but better late than never.

Summary by CodeRabbit

Release Notes

• Refactor
  • Optimized alert icon rendering in the account events timeline chart for improved performance and consistency.

[netlify]

✅ Deploy Preview for agentscan ready!

Name	Link
🔨 Latest commit	56f8ea2
🔍 Latest deploy log	https://app.netlify.com/projects/agentscan/deploys/6a097993e1664200083a390d
😎 Deploy Preview	https://deploy-preview-129--agentscan.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a6ac627-03b5-4325-ae48-b44b2ba9afbb

📥 Commits

Reviewing files that changed from the base of the PR and between 18e2980 and 56f8ea2.

📒 Files selected for processing (1)

• app/components/Chart/AccountEventsTimeline.vue

---

📝 Walkthrough

Walkthrough

A Vue component consolidates the zap SVG path definition into a reusable helper function that accepts x/y coordinates, then applies this helper to both the tooltip alert icon and the chart overlay. The overlay also switches to using v-show for visibility control.

Changes

SVG Icon Path Centralization

Layer / File(s)	Summary
Zap icon path helper extraction app/components/Chart/AccountEventsTimeline.vue	New getZapIconPath({ x, y }) helper function centralizes the zap icon SVG path definition and accepts coordinate parameters for reuse.
Icon rendering with helper function app/components/Chart/AccountEventsTimeline.vue	Tooltip alert icon and custom SVG overlay integrate the centralized helper; overlay also transitions from conditional rendering (v-if) to visibility toggle (v-show).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• MatteoGabriele/agentscan#123: Overlapping modifications to zap/alert icon SVG rendering and path generation in the same timeline chart component.

Suggested reviewers

• MatteoGabriele

Poem

🐇 A path once scattered, now takes shape,
Through helper's hands, coordinates escape.
Tooltip and overlay, now unified,
Where zap icons shine, side by side! ⚡

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'refactor: account chart cleanup' is vague and generic, using non-descriptive terms that don't convey the specific technical changes made to the codebase.	Consider a more specific title like 'refactor: centralize zap icon SVG path in AccountEventsTimeline' to better describe the actual changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MatteoGabriele]