Skip to content

refactor: account chart cleanup #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoGabriele merged 1 commit into from
May 17, 2026
Merged

refactor: account chart cleanup #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions app/components/Chart/AccountEventsTimeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,11 @@ const tooltipTimeLabels = computed<string[]>(() => {
function getTooltipTimeLabel(index: number): string {
return tooltipTimeLabels.value[index] ?? "";
}

function getZapIconPath({ x, y }: { x: number; y: number }) {
// ⚡ with relative coordinates from initial position
return `M ${x} ${y} l 12 -17 l -6 0 l 3 -13 l -11 17 l 6 0 l -4 13`;
}
</script>

<template>
Expand All @@ -432,14 +437,6 @@ function getTooltipTimeLabel(index: number): string {
</linearGradient>
</template>

<!-- Remove this if you don't want the total series as bars -->
<template #bar-gradient="{ series, positiveId }">
<linearGradient :id="positiveId" x1="0" x2="0" y1="0" y2="1">
<stop offset="0%" :stop-color="series.color" stop-opacity="0.3" />
<stop offset="100%" :stop-color="colors.bg" stop-opacity="0" />
</linearGradient>
</template>

<!-- Custom tooltip -->
<template #tooltip="{ datapoint, seriesIndex }">
<div class="flex flex-col">
Expand All @@ -465,7 +462,7 @@ function getTooltipTimeLabel(index: number): string {
aria-hidden="true"
>
<path
d="M 2 30 L 14 13 L 8 13 L 11 0 L 0 17 L 6 17 L 2 30"
:d="getZapIconPath({ x: 2, y: 30 })"
:fill="colors.amber"
:stroke="colors.bg"
/>
Expand Down Expand Up @@ -506,9 +503,13 @@ function getTooltipTimeLabel(index: number): string {
:key="`${alerts.name}-${plot.absoluteIndex}`"
>
<path
v-if="plot.isAlert"
class="svg-element-transition"
:d="`M ${plot.x - 4} ${plot.y - 6} l 12 -17 l -6 0 l 3 -13 l -11 17 l 6 0 l -4 13`"
v-show="plot.isAlert"
:d="
getZapIconPath({
x: plot.x - 4,
y: plot.y - 6,
})
"
:fill="colors.amber"
:stroke="colors.bg"
/>
Expand Down
Loading