feat: add landmarks to health chart#210
Merged
MatteoGabriele merged 19 commits intoJul 1, 2026
Merged
Conversation
✅ Deploy Preview for agentscan ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Chart/GlobalEventsEvolution.vue`:
- Around line 275-277: The v-for loop iterating through keyDates using landmark
and index j currently binds the key to landmark?.name which is not guaranteed to
be unique and can cause incorrect vnode reuse in Vue when duplicate landmark
names exist. Replace the :key binding in the v-for directive to use a unique
identifier by either using the index j directly or combining the landmark name
with its index position to ensure uniqueness across all iterations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c264624a-ce93-4ad9-bf8d-66c20305457e
📒 Files selected for processing (1)
app/components/Chart/GlobalEventsEvolution.vue
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Chart/GlobalEventsEvolution.vue`:
- Around line 222-225: The sample event date in GlobalEventsEvolution.vue is
still using the demo landmark instead of the production one; update the date
field in the relevant event object from the placeholder value to the real sample
update date referenced by the inline FIXME so the chart uses the correct
before/after window. Use the event entry containing name "Sample update" and
description "13 repositories added to the dataset" to locate it, and make sure
no demo-only date remains in that dataset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 15b1b059-e0c4-41ed-97c5-5da43138fe5a
📒 Files selected for processing (1)
app/components/Chart/GlobalEventsEvolution.vue
graphieros
force-pushed
the
health-chart-landmarks
branch
from
e02c8b5 to
9c812f6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/Chart/GlobalEventsEvolution.vue`:
- Line 222: The single-line guard clauses in GlobalEventsEvolution.vue are
violating the repo’s curly lint rule. Update the affected `if` statements to use
braces in the relevant logic around `lastDate` and the other matching guard at
the referenced spot, keeping the same behavior but wrapping each conditional
branch in a block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: abddb538-ec81-4591-9493-04d5888fae27
📒 Files selected for processing (1)
app/components/Chart/GlobalEventsEvolution.vue
Owner
|
How do you plan to drop this one? |
Collaborator
Author
It needs your final touch on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a landmark on the chart to signal the packages sample update(s).
It is designed to become visible when the date of the landmark is a week older than the last datapoint.
Here is a screenshot with the landmark positioned at an earlier date so it is visible for the demo:
Tooltip shows the details of the landmark when hovering its index:
This is probably a temporary feature, designed to facilitate the before/after trend analysis.
Summary by CodeRabbit
Summary of Changes