Fixing shadow rendering

Excluding option

Author: larsbrubaker

RenderGl/NativeSceneRenderer.cs

@@ -63,6 +63,8 @@ public sealed class MeshRenderCommand
 
 		public bool BlendTexture { get; init; } = true;
 
+		public bool CastsBedShadow { get; init; } = true;
+
 		public Color Color { get; init; }
 
 		public bool ForceCullBackFaces { get; init; } = true;

RenderGl/RenderHelper.cs

@@ -54,6 +54,8 @@ public static class RenderHelper
 
 		private const float GL_REPLACE = (float)0x1E01;
 
+		private static int suppressBedShadowCastingDepth;
+
 		public static void ExtendLineEnds(ref Vector3 start, ref Vector3 end, double length)
 		{
 			// extend both sides
@@ -85,6 +87,78 @@ public static void PrepareFor3DLineRender(bool doDepthTest)
 			}
 		}
 
+		public static MeshRenderCommand CreateBedShadowCommand(MeshRenderCommand command)
+		{
+			if (command == null)
+			{
+				return null;
+			}
+
+			return new MeshRenderCommand
+			{
+				Mesh = command.Mesh,
+				Color = command.Color,
+				Transform = command.Transform,
+				RenderType = command.RenderType,
+				MeshToViewTransform = command.MeshToViewTransform,
+				WireFrameColor = command.WireFrameColor,
+				MeshChanged = command.MeshChanged,
+				BlendTexture = command.BlendTexture,
+				AllowBspRendering = command.AllowBspRendering,
+				ForceCullBackFaces = false,
+				IsSelected = command.IsSelected,
+				OverrideFaceColors = command.OverrideFaceColors,
+				AlphaMultiplier = command.AlphaMultiplier,
+				Unlit = command.Unlit,
+				CastsBedShadow = command.CastsBedShadow,
+			};
+		}
+
+		public static bool ResolveBedShadowCasting(bool castsBedShadow)
+		{
+			return castsBedShadow
+				&& suppressBedShadowCastingDepth == 0;
+		}
+
+		public static bool ShouldRenderInBedShadow(MeshRenderCommand command, RectangleDouble bedBounds)
+		{
+			if (command?.Mesh == null
+				|| !command.CastsBedShadow)
+			{
+				return false;
+			}
+
+			switch (command.RenderType)
+			{
+				case RenderTypes.Shaded:
+				case RenderTypes.Outlines:
+				case RenderTypes.NonManifold:
+				case RenderTypes.Wireframe:
+				case RenderTypes.Polygons:
+					break;
+
+				default:
+					return false;
+			}
+
+			var bounds = command.Mesh.GetAxisAlignedBoundingBox(command.Transform);
+			if (bounds.MaxXYZ.Z <= 0)
+			{
+				return false;
+			}
+
+			return !(bounds.MaxXYZ.X < bedBounds.Left
+				|| bounds.MinXYZ.X > bedBounds.Right
+				|| bounds.MaxXYZ.Y < bedBounds.Bottom
+				|| bounds.MinXYZ.Y > bedBounds.Top);
+		}
+
+		public static IDisposable SuppressBedShadowCasting()
+		{
+			suppressBedShadowCastingDepth++;
+			return new DisposableScope(() => suppressBedShadowCastingDepth--);
+		}
+
 		public static void Render(Mesh meshToRender,
 			Color partColor,
 			RenderTypes renderType = RenderTypes.Shaded,
@@ -93,11 +167,12 @@ public static void Render(Mesh meshToRender,
             Action meshChanged = null,
 			bool blendTexture = true,
 			bool forceCullBackFaces = true,
+			bool castsBedShadow = true,
 			bool isSelected = false,
 			bool overrideFaceColors = false,
 			float alphaMultiplier = 1.0f)
 		{
-			Render(meshToRender, partColor, Matrix4X4.Identity, renderType, meshToViewTransform, wireFrameColor, meshChanged, blendTexture, forceCullBackFaces: forceCullBackFaces, isSelected: isSelected, overrideFaceColors: overrideFaceColors, alphaMultiplier: alphaMultiplier);
+			Render(meshToRender, partColor, Matrix4X4.Identity, renderType, meshToViewTransform, wireFrameColor, meshChanged, blendTexture, forceCullBackFaces: forceCullBackFaces, castsBedShadow: castsBedShadow, isSelected: isSelected, overrideFaceColors: overrideFaceColors, alphaMultiplier: alphaMultiplier);
 		}
 
 		public static void Render(Mesh meshToRender,
@@ -110,6 +185,7 @@ public static void Render(Mesh meshToRender,
 			bool blendTexture = true,
 			bool allowBspRendering = false,
 			bool forceCullBackFaces = true,
+			bool castsBedShadow = true,
 			bool isSelected = false,
 			bool overrideFaceColors = false,
 			float alphaMultiplier = 1.0f)
@@ -130,6 +206,7 @@ public static void Render(Mesh meshToRender,
 						BlendTexture = blendTexture,
 						AllowBspRendering = allowBspRendering,
 						ForceCullBackFaces = forceCullBackFaces,
+						CastsBedShadow = ResolveBedShadowCasting(castsBedShadow),
 						IsSelected = isSelected,
 						OverrideFaceColors = overrideFaceColors,
 						AlphaMultiplier = alphaMultiplier,
@@ -469,5 +546,27 @@ public static void UnsetGlContext()
 
 			GL.PopAttrib();
 		}
+
+		private sealed class DisposableScope : IDisposable
+		{
+			private readonly Action onDispose;
+			private bool disposed;
+
+			public DisposableScope(Action onDispose)
+			{
+				this.onDispose = onDispose;
+			}
+
+			public void Dispose()
+			{
+				if (disposed)
+				{
+					return;
+				}
+
+				disposed = true;
+				onDispose?.Invoke();
+			}
+		}
 	}
 }

RenderGl/Renderer/Graphics2DGpu.cs

@@ -600,6 +600,7 @@ public void RenderTransformedPath(Matrix4X4 transform, IVertexSource path, Color
                         RenderType = RenderTypes.Shaded,
                         BlendTexture = false,
                         ForceCullBackFaces = false,
+						CastsBedShadow = false,
                         Unlit = true,
                     };
 

VorticeD3D/NativeSceneEffects.cs

@@ -48,8 +48,8 @@ namespace MatterHackers.RenderGl
 	public partial class VorticeD3DGl
 	{
 		private const int BedCompositeTextureSize = 2048;
-		private const int BedShadowTextureSize = 512;
-		private const float BedShadowStrength = .35f;
+		private const int BedShadowTextureSize = 2048;
+		private const float BedShadowStrength = .70f;
 		private const float BedShadowViewDistance = 1000;
 		private const int SceneEffectVertexFloatStride = SceneEdgeShaderDataPlugin.TotalVertexFloatStride;
 		private const int SceneEffectVertexStride = SceneEffectVertexFloatStride * sizeof(float);
@@ -758,30 +758,18 @@ private void RenderBedShadowMask(BedRenderCommand bedCommand)
 					continue;
 				}
 
-				RenderFlatMask(command, command.Transform * shadowView, shadowProjection, AggColor.Black, enableDepthTest: false);
+				// Glyph meshes can have mixed winding on their caps and sides; forcing the
+				// shadow mask to render without culling avoids clipped letter silhouettes.
+				var shadowCommand = RenderHelper.CreateBedShadowCommand(command);
+				RenderFlatMask(shadowCommand, shadowCommand.Transform * shadowView, shadowProjection, AggColor.Black, enableDepthTest: false);
 			}
 
 			UnbindSceneTextures();
 		}
 
 		private static bool ShouldRenderCommandIntoBedShadow(MeshRenderCommand command, RectangleDouble bedBounds)
 		{
-			if (command?.Mesh == null
-				|| !SceneRenderModeUtilities.RequiresSceneMeshPass(command.RenderType))
-			{
-				return false;
-			}
-
-			var bounds = command.Mesh.GetAxisAlignedBoundingBox(command.Transform);
-			if (bounds.MaxXYZ.Z <= 0)
-			{
-				return false;
-			}
-
-			return !(bounds.MaxXYZ.X < bedBounds.Left
-				|| bounds.MinXYZ.X > bedBounds.Right
-				|| bounds.MaxXYZ.Y < bedBounds.Bottom
-				|| bounds.MinXYZ.Y > bedBounds.Top);
+			return RenderHelper.ShouldRenderInBedShadow(command, bedBounds);
 		}
 
 		private void RenderBedBlurPass(ID3D11ShaderResourceView sourceTexture, ColorTextureTarget destinationTarget, float directionX, float directionY)