Skip to content

perf: bypass ConcreteInstr validation in from_code via _from_opcode #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthieuDartiailh merged 1 commit into from
May 11, 2026
Merged

perf: bypass ConcreteInstr validation in from_code via _from_opcode #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/bytecode/concrete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,24 @@ def assemble(self) -> bytes:

return bytes(b)

@classmethod
def _from_opcode(
cls: Type[T],
name: str,
opcode: int,
arg: int,
location: Optional[InstrLocation],
) -> T:
"""Fast path for from_code: arg is a raw byte (0-255), size is always 2."""
new = object.__new__(cls)
new._name = name
new._opcode = opcode
new._arg = arg
new._location = location
new._extended_args = None
new._size = 2
return new

@classmethod
def disassemble(cls: Type[T], lineno: Optional[int], code: bytes, offset: int) -> T:
index = 2 * offset
Expand Down Expand Up @@ -353,7 +371,7 @@ def from_code(
loc: Optional[InstrLocation] = (
InstrLocation._from_tuple(*pos) if pos is not None else None
)
instructions.append(ConcreteInstr(opname[op], arg, location=loc))
instructions.append(ConcreteInstr._from_opcode(opname[op], op, arg, loc))

bytecode = ConcreteBytecode()

Expand Down