fix: match correct try block markers in CFG#205
Merged
MatthieuDartiailh merged 3 commits intoJun 3, 2026
Merged
Conversation
Fix an ``AssertionError`` in stack-size computation when a single exception region is split into multiple ``TryBegin`` instances sharing one handler (as produced by bytecode-rewriting tools that wrap a whole function body in a single handler). ``TryBegin``/``TryEnd`` are now matched on the handler block rather than on ``TryBegin`` identity.
Contributor
Author
|
@MatthieuDartiailh I think this is late to the 0.18.0 party 🙁 Could we have a 0.18.1 once this is merged? 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 7 7
Lines 2135 2135
Branches 459 459
=======================================
Hits 2038 2038
Misses 54 54
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
MatthieuDartiailh
left a comment
MatthieuDartiailh
left a comment
There was a problem hiding this comment.
LGTM
Let me know when this is ready and I will release ASAP
Co-authored-by: Matthieu Dartiailh <marul@laposte.net>
Contributor
Author
|
@MatthieuDartiailh this should now be ready 🙇 |
P403n1x87
force-pushed
the
fix/try-block-across-jump-target
branch
from
b76bb2d to
7969a6b
Compare
MatthieuDartiailh
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an
AssertionErrorin stack-size computation when a single exception region is split into multipleTryBegininstances sharing one handler (as produced by bytecode-rewriting tools that wrap a whole function body in a single handler).TryBegin/TryEndare now matched on the handler block rather than onTryBeginidentity.