Merge pull request #53 from MaxLinCode/codex/turn-routing-refactor

Refactor turn routing: 3-layer pipeline (classify → extract → commit)

Author: MaxLinCode

CLAUDE.md

@@ -28,6 +28,7 @@ const {
   sendTelegramMessageMock,
   sendTelegramChatActionMock,
   routeTurnWithResponsesMock,
+  classifyTurnWithResponsesMock,
   summarizeConversationMemoryWithResponsesMock,
   respondToConversationTurnWithResponsesMock,
   recoverConfirmedMutationWithResponsesMock
@@ -36,6 +37,7 @@ const {
   sendTelegramMessageMock: vi.fn(),
   sendTelegramChatActionMock: vi.fn(),
   routeTurnWithResponsesMock: vi.fn(),
+  classifyTurnWithResponsesMock: vi.fn(),
   summarizeConversationMemoryWithResponsesMock: vi.fn(),
   respondToConversationTurnWithResponsesMock: vi.fn(),
   recoverConfirmedMutationWithResponsesMock: vi.fn()
@@ -80,6 +82,7 @@ vi.mock("@atlas/integrations", async () => {
     editTelegramMessage: editTelegramMessageMock,
     respondToConversationTurnWithResponses: respondToConversationTurnWithResponsesMock,
     recoverConfirmedMutationWithResponses: recoverConfirmedMutationWithResponsesMock,
+    classifyTurnWithResponses: classifyTurnWithResponsesMock,
     routeTurnWithResponses: routeTurnWithResponsesMock,
     sendTelegramChatAction: sendTelegramChatActionMock,
     sendTelegramMessage: sendTelegramMessageMock,
@@ -147,7 +150,8 @@ function buildRoutedTurn(input: {
         ? { mutationInputSource: "recovered_proposal" as const }
         : input.action === "execute_mutation"
           ? { mutationInputSource: "direct_user_turn" as const }
-          : {})
+          : {}),
+      committedSlots: {}
     }
   };
 }
@@ -275,13 +279,19 @@ beforeEach(async () => {
   sendTelegramMessageMock.mockReset();
   sendTelegramChatActionMock.mockReset();
   routeTurnWithResponsesMock.mockReset();
+  classifyTurnWithResponsesMock.mockReset();
   summarizeConversationMemoryWithResponsesMock.mockReset();
   respondToConversationTurnWithResponsesMock.mockReset();
   recoverConfirmedMutationWithResponsesMock.mockReset();
   routeTurnWithResponsesMock.mockResolvedValue({
     route: "mutation",
     reason: "Direct scheduling request."
   });
+  classifyTurnWithResponsesMock.mockResolvedValue({
+    turnType: "planning_request",
+    confidence: 0.92,
+    reasoning: "User wants to schedule or plan something."
+  });
   summarizeConversationMemoryWithResponsesMock.mockResolvedValue({
     summary: "Recent conversation summary."
   });
@@ -522,6 +532,11 @@ describe("telegram webhook route", () => {
     const conversationResponder = vi.fn(async () => ({
       reply: "What time tomorrow should I schedule the dentist?"
     }));
+    classifyTurnWithResponsesMock.mockResolvedValue({
+      turnType: "planning_request",
+      confidence: 0.55,
+      reasoning: "Mixed-intent message with ambiguous scheduling request."
+    });
 
     const response = await handleTelegramWebhook(
       buildRequest({

apps/web/src/app/api/telegram/webhook/route.test.ts

@@ -33,7 +33,8 @@ describe("deriveConversationReplyState", () => {
     const result = deriveConversationReplyState({
       snapshot: buildSnapshot(),
       policy: {
-        action: "ask_clarification"
+        action: "ask_clarification",
+        committedSlots: {}
       },
       interpretation: {
         turnType: "planning_request",
@@ -71,7 +72,8 @@ describe("deriveConversationReplyState", () => {
       snapshot: buildSnapshot(),
       policy: {
         action: "ask_clarification",
-        clarificationSlots: ["proposal"]
+        clarificationSlots: ["proposal"],
+        committedSlots: {}
       },
       interpretation: {
         turnType: "confirmation",
@@ -94,7 +96,8 @@ describe("deriveConversationReplyState", () => {
     const result = deriveConversationReplyState({
       snapshot: buildSnapshot(),
       policy: {
-        action: "ask_clarification"
+        action: "ask_clarification",
+        committedSlots: {}
       },
       interpretation: {
         turnType: "unknown",
@@ -154,7 +157,8 @@ describe("deriveConversationReplyState", () => {
     const result = deriveConversationReplyState({
       snapshot,
       policy: {
-        action: "present_proposal"
+        action: "present_proposal",
+        committedSlots: {}
       },
       interpretation: {
         turnType: "clarification_answer",

apps/web/src/lib/server/conversation-state.test.ts

@@ -19,7 +19,7 @@ import { type ProcessedInboxResult } from "@atlas/db";
 
 type DeriveConversationReplyStateInput = {
   snapshot: ConversationStateSnapshot;
-  policy: Pick<TurnPolicyDecision, "action" | "clarificationSlots" | "targetProposalId"> & {
+  policy: Pick<TurnPolicyDecision, "action" | "clarificationSlots" | "targetProposalId" | "committedSlots"> & {
     action: Extract<TurnPolicyAction, "reply_only" | "ask_clarification" | "present_proposal">;
   };
   interpretation: TurnInterpretation;
@@ -134,7 +134,7 @@ export function deriveConversationReplyState(input: DeriveConversationReplyState
     });
     nextFocusEntityId ??= clarificationEntity.id;
   }
-  const nextDiscourseState = updateDiscourseStateFromAssistantTurn(discourseState, {
+  const updatedDiscourseState = updateDiscourseStateFromAssistantTurn(discourseState, {
     ...(presentedItems.length > 0 ? { presentedItems } : {}),
     ...(newClarifications.length > 0 ? { newClarifications } : {}),
     ...(resolvedClarificationIds.length > 0 ? { resolvedClarificationIds } : {}),
@@ -143,6 +143,12 @@ export function deriveConversationReplyState(input: DeriveConversationReplyState
     validEntityIds: entityRegistry.map((entity) => entity.id)
   }).state;
 
+  const committedSlots = input.policy.committedSlots;
+  const nextDiscourseState =
+    committedSlots && Object.keys(committedSlots).length > 0
+      ? { ...updatedDiscourseState, resolved_slots: committedSlots }
+      : updatedDiscourseState;
+
   return {
     summaryText: input.summaryText,
     mode: getConversationModeForPolicy(input.policy.action),