Merge pull request #52 from MaxLinCode/codex/fix-block-slot

Clean up blocking slots

Author: MaxLinCode

apps/web/src/lib/server/interpret-turn.test.ts

@@ -198,6 +198,70 @@ describe("interpretTurn", () => {
     });
   });
 
+  it("clears a satisfied time clarification slot when the answer provides a clock time", async () => {
+    const result = await interpretTurn({
+      rawText: "5pm",
+      normalizedText: "5pm",
+      recentTurns: [],
+      discourseState: {
+        focus_entity_id: null,
+        currently_editable_entity_id: null,
+        last_user_mentioned_entity_ids: [],
+        last_presented_items: [],
+        pending_clarifications: [
+          {
+            id: "clar-1",
+            slot: "time",
+            question: "What time should I schedule it?",
+            status: "pending",
+            blocking: true,
+            createdAt: "2026-03-20T16:00:00.000Z",
+            createdTurnId: "assistant:1"
+          }
+        ],
+        mode: "clarifying"
+      }
+    });
+
+    expect(result).toMatchObject({
+      turnType: "clarification_answer",
+      ambiguity: "none"
+    });
+    expect(result.missingSlots).toBeUndefined();
+  });
+
+  it("treats punctuated consent as confirmation when one active proposal exists", async () => {
+    const result = await interpretTurn({
+      rawText: "Ok,",
+      normalizedText: "Ok,",
+      recentTurns: [],
+      entityRegistry: [
+        {
+          id: "proposal-1",
+          conversationId: "conversation-1",
+          kind: "proposal_option",
+          label: "Schedule it at 5pm",
+          status: "active",
+          createdAt: "2026-03-20T16:00:00.000Z",
+          updatedAt: "2026-03-20T16:00:00.000Z",
+          data: {
+            route: "conversation_then_mutation",
+            replyText: "Would you like me to schedule it at 5pm?",
+            confirmationRequired: true,
+            targetEntityId: null,
+            mutationInputSource: null
+          }
+        }
+      ]
+    });
+
+    expect(result).toMatchObject({
+      turnType: "confirmation",
+      resolvedProposalId: "proposal-1",
+      ambiguity: "none"
+    });
+  });
+
   it("treats informational questions as informational", async () => {
     const result = await interpretTurn({
       rawText: "What do I have tomorrow?",

apps/web/src/lib/server/interpret-turn.ts

@@ -58,7 +58,12 @@ export async function interpretTurn(input: InterpretTurnInput): Promise<TurnInte
   }
 
   if (clarificationLike) {
-    const ambiguity = blockingSlots.length > 0 ? "high" : "none";
+    const unresolvedBlockingSlots = deriveClarificationAnswerMissingSlots({
+      blockingSlots,
+      writeSignals,
+      resolvedEntityIds
+    });
+    const ambiguity = unresolvedBlockingSlots.length > 0 ? "high" : "none";
 
     return {
       turnType: "clarification_answer",
@@ -69,7 +74,7 @@ export async function interpretTurn(input: InterpretTurnInput): Promise<TurnInte
       ...(ambiguity === "high"
         ? { ambiguityReason: "Blocking clarification slots are still open." }
         : {}),
-      ...(blockingSlots.length > 0 ? { missingSlots: blockingSlots } : {})
+      ...(unresolvedBlockingSlots.length > 0 ? { missingSlots: unresolvedBlockingSlots } : {})
     };
   }
 
@@ -156,7 +161,7 @@ function unique(values: string[]) {
 }
 
 function isConfirmationTurn(lower: string) {
-  return /^(yes|yeah|yep|ok|okay|do it|sounds good|works|that works|go ahead|please do|confirm)([.! ]*)?$/.test(
+  return /^(yes|yeah|yep|ok|okay|do it|sounds good|works|that works|go ahead|please do|confirm)([.,!? ]*)?$/.test(
     lower
   );
 }
@@ -299,6 +304,30 @@ function deriveMissingSlots(input: {
   return unique(missingSlots);
 }
 
+function deriveClarificationAnswerMissingSlots(input: {
+  blockingSlots: string[];
+  writeSignals: ReturnType<typeof analyzeWriteSignals>;
+  resolvedEntityIds: string[];
+}) {
+  return unique(
+    input.blockingSlots.filter((slot) => {
+      switch (slot) {
+        case "day":
+          return !input.writeSignals.hasDayReference;
+        case "time":
+          return !input.writeSignals.hasClockTime;
+        case "target":
+          return input.resolvedEntityIds.length === 0 && !input.writeSignals.hasConcreteSubject;
+        case "proposal":
+        case "unknown":
+          return true;
+        default:
+          return true;
+      }
+    })
+  );
+}
+
 function deriveWriteAmbiguity(input: {
   normalizedText: string;
   resolvedEntityIds: string[];

apps/web/src/lib/server/turn-router.test.ts

@@ -66,4 +66,48 @@ describe("turn router", () => {
       }
     });
   });
+
+  it("routes punctuated consent on an active proposal to recover-and-execute", async () => {
+    const result = await routeMessageTurn({
+      rawText: "Ok,",
+      normalizedText: "Ok,",
+      recentTurns: [
+        {
+          role: "assistant",
+          text: "Would you like me to schedule it at 5pm?",
+          createdAt: "2026-03-17T16:00:00.000Z"
+        }
+      ],
+      entityRegistry: [
+        {
+          id: "proposal-1",
+          conversationId: "conversation-1",
+          kind: "proposal_option",
+          label: "Schedule it at 5pm",
+          status: "active",
+          createdAt: "2026-03-17T16:00:00.000Z",
+          updatedAt: "2026-03-17T16:00:00.000Z",
+          data: {
+            route: "conversation_then_mutation",
+            replyText: "Would you like me to schedule it at 5pm?",
+            confirmationRequired: true,
+            originatingTurnText: "Schedule Malaysia trip planning at 5pm",
+            targetEntityId: null,
+            mutationInputSource: null
+          }
+        }
+      ]
+    });
+
+    expect(result).toMatchObject({
+      interpretation: {
+        turnType: "confirmation",
+        resolvedProposalId: "proposal-1"
+      },
+      policy: {
+        action: "recover_and_execute",
+        targetProposalId: "proposal-1"
+      }
+    });
+  });
 });