Fix phantom pending_write_operation on reply_only turns; rename missingSlots to missingFields

- turn-router: only build resolvedOperation when policy.action !== "reply_only";
  informational and follow_up_reply turns were creating a synthetic PendingWriteOperation
  that overwrote any real in-progress write workflow in discourse state
- core/index: rename turnInterpretationSchema field missingSlots → missingFields to
  match the PendingWriteOperation naming introduced in phase 1
- update tests to assert reply_only turns produce no resolvedOperation, and fix
  missingSlots references in conversation-state.test.ts

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: MaxLinCode

apps/web/src/lib/server/conversation-state.test.ts

@@ -62,7 +62,7 @@ describe("deriveConversationReplyState", () => {
         confidence: 0.58,
         resolvedEntityIds: [],
         ambiguity: "high",
-        missingSlots: ["time"],
+        missingFields: ["time"],
       },
       reply: "What time should I schedule the Malaysia trip planning?",
       userTurnText: "schedule malaysia trip planning tomorrow",
@@ -122,7 +122,7 @@ describe("deriveConversationReplyState", () => {
         confidence: 0.42,
         resolvedEntityIds: [],
         ambiguity: "high",
-        missingSlots: ["unknown"],
+        missingFields: ["unknown"],
       },
       reply: "Can you clarify what you want me to change?",
       userTurnText: "do it",
@@ -225,7 +225,7 @@ describe("deriveConversationReplyState", () => {
         confidence: 0.58,
         resolvedEntityIds: [],
         ambiguity: "high",
-        missingSlots: ["time"],
+        missingFields: ["time"],
       },
       reply: "What time should I schedule it?",
       userTurnText: "schedule gym tomorrow",

apps/web/src/lib/server/turn-router.test.ts

@@ -172,7 +172,7 @@ describe("turn router", () => {
     });
   });
 
-  it("includes resolvedOperation with empty resolvedFields for non-planning turns", async () => {
+  it("does not set resolvedOperation for reply_only turns", async () => {
     mockClassification({
       turnType: "informational",
       confidence: 0.93,
@@ -184,10 +184,8 @@ describe("turn router", () => {
       recentTurns: [],
     });
 
-    expect(result.policy.resolvedOperation).toMatchObject({
-      operationKind: "plan",
-      resolvedFields: {},
-    });
+    expect(result.policy.action).toBe("reply_only");
+    expect(result.policy.resolvedOperation).toBeUndefined();
   });
 
   it("includes resolvedOperation with extracted fields for planning_request", async () => {

apps/web/src/lib/server/turn-router.ts

@@ -117,13 +117,18 @@ export async function routeMessageTurn(
     routingContext: input,
   });
 
-  // Assemble the resolved PendingWriteOperation to carry through to state persistence.
-  const resolvedOperation = buildResolvedOperation(
-    operationKind,
-    commitResult,
-    priorOperation,
-    input.normalizedText,
-  );
+  // Assemble the resolved PendingWriteOperation for any turn that advances or maintains
+  // a write workflow. reply_only turns must not create or overwrite pending_write_operation
+  // in discourse state — they carry no write intent.
+  const resolvedOperation =
+    policy.action !== "reply_only"
+      ? buildResolvedOperation(
+          operationKind,
+          commitResult,
+          priorOperation,
+          input.normalizedText,
+        )
+      : undefined;
 
   // Build interpretation for backward compatibility
   const interpretation = buildInterpretation(classification, commitResult);
@@ -187,7 +192,7 @@ function buildInterpretation(
           ),
         }
       : {}),
-    ...(allMissingFields.length > 0 ? { missingSlots: allMissingFields } : {}),
+    ...(allMissingFields.length > 0 ? { missingFields: allMissingFields } : {}),
   };
 }
 

packages/core/src/index.ts

@@ -925,7 +925,7 @@ export const turnInterpretationSchema = z.object({
   resolvedProposalId: z.string().min(1).optional(),
   ambiguity: turnAmbiguitySchema,
   ambiguityReason: z.string().min(1).optional(),
-  missingSlots: z.array(z.string().min(1)).optional(),
+  missingFields: z.array(z.string().min(1)).optional(),
   notes: z.array(z.string().min(1)).optional(),
 });