Harden slot normalizer

Author: MaxLinCode

packages/core/src/index.ts

@@ -851,12 +851,12 @@ const slotConfidenceSchema = z.object({
 });
 
 export const rawSlotExtractionSchema = z.object({
-  time: z.object({ hour: z.number().int(), minute: z.number().int() }).nullable(),
+  time: z.object({ hour: z.number().int().min(0).max(23), minute: z.number().int().min(0).max(59) }).nullable(),
   day: z.object({
     kind: z.enum(["relative", "weekday", "absolute"]),
     value: z.string()
   }).nullable(),
-  duration: z.object({ minutes: z.number().int() }).nullable(),
+  duration: z.object({ minutes: z.number().int().min(0) }).nullable(),
   target: z.object({ entityId: z.string() }).nullable(),
   confidence: slotConfidenceSchema,
   unresolvable: z.array(slotKeySchema)

packages/core/src/slot-normalizer.test.ts

@@ -46,6 +46,22 @@ describe("normalizeRawExtraction", () => {
     });
   });
 
+  it("drops time when hour is out of range", () => {
+    expect(normalizeRawExtraction(extraction({ time: { hour: 25, minute: 0 } }))).toEqual({});
+  });
+
+  it("drops time when minute is out of range", () => {
+    expect(normalizeRawExtraction(extraction({ time: { hour: 10, minute: 70 } }))).toEqual({});
+  });
+
+  it("drops time when hour is negative", () => {
+    expect(normalizeRawExtraction(extraction({ time: { hour: -1, minute: 0 } }))).toEqual({});
+  });
+
+  it("drops duration when minutes is negative", () => {
+    expect(normalizeRawExtraction(extraction({ duration: { minutes: -30 } }))).toEqual({});
+  });
+
   it("returns empty object when no slots present", () => {
     expect(normalizeRawExtraction(extraction({}))).toEqual({});
   });

packages/core/src/slot-normalizer.ts

@@ -3,15 +3,15 @@ import type { RawSlotExtraction, ResolvedSlots } from "./index";
 export function normalizeRawExtraction(raw: RawSlotExtraction): Partial<ResolvedSlots> {
   const result: Partial<ResolvedSlots> = {};
 
-  if (raw.time) {
+  if (raw.time && raw.time.hour >= 0 && raw.time.hour <= 23 && raw.time.minute >= 0 && raw.time.minute <= 59) {
     result.time = `${String(raw.time.hour).padStart(2, "0")}:${String(raw.time.minute).padStart(2, "0")}`;
   }
 
   if (raw.day) {
     result.day = raw.day.kind === "absolute" ? raw.day.value : raw.day.value.toLowerCase();
   }
 
-  if (raw.duration) {
+  if (raw.duration && raw.duration.minutes >= 0) {
     result.duration = raw.duration.minutes;
   }