Skip to content

Commit 0d9e692

Browse files
committed
test: fix ExportServiceTest on CI, reduce compiler warnings
- ExportServiceTest: use initForTests with in-memory SQLite so tests do not depend on Postgres in CI (fixes ExposedSQLException/PSQLException) - Remove unnecessary !! and safe calls in EvaluationCompatibilityTest, FlagRepositoryTest; fix FirebaseAnalyticsReporterTest nullable URL; add @Suppress for AppConfigTest USELESS_IS_CHECK and PerformanceTest UNCHECKED_CAST Made-with: Cursor
1 parent e9d462c commit 0d9e692

6 files changed

Lines changed: 15 additions & 13 deletions

File tree

backend/src/test/kotlin/flagent/compatibility/EvaluationCompatibilityTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ class EvaluationCompatibilityTest {
118118
assertNotNull(evalContext)
119119
val ctxObj = evalContext as? kotlinx.serialization.json.JsonObject
120120
assertNotNull(ctxObj)
121-
assertTrue(ctxObj!!.containsKey("entityID"))
121+
assertTrue(ctxObj.containsKey("entityID"))
122122
assertTrue(ctxObj.containsKey("entityType"))
123123
assertTrue(ctxObj.containsKey("entityContext"))
124124
assertEquals("user_123", ctxObj["entityID"]?.toString()?.trim('"'))
@@ -268,11 +268,11 @@ class EvaluationCompatibilityTest {
268268

269269
val results = batchResult["evaluationResults"]?.let { it as? kotlinx.serialization.json.JsonArray }
270270
assertNotNull(results)
271-
assertEquals(2, results!!.size)
271+
assertEquals(2, results.size)
272272

273273
val firstResult = results[0] as? kotlinx.serialization.json.JsonObject
274274
assertNotNull(firstResult)
275-
assertTrue(firstResult!!.containsKey("flagID"))
275+
assertTrue(firstResult.containsKey("flagID"))
276276
assertTrue(firstResult.containsKey("evalContext"))
277277
} finally {
278278
client.close()

backend/src/test/kotlin/flagent/config/AppConfigTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ class AppConfigTest {
6565

6666
@Test
6767
fun middlewareVerboseLoggerExcludeURLsIsList() {
68+
@Suppress("USELESS_IS_CHECK") // Config type is List; test documents the contract
6869
assertTrue(AppConfig.middlewareVerboseLoggerExcludeURLs is List<*>)
6970
}
7071

backend/src/test/kotlin/flagent/integration/firebase/FirebaseAnalyticsReporterTest.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,9 @@ class FirebaseAnalyticsReporterTest {
9191
reporter.close()
9292

9393
assertEquals(1, requestCount)
94-
assertTrue(capturedUrl?.contains("measurement_id=G-XXX") == true)
95-
assertTrue(capturedUrl?.contains("api_secret=secret") == true)
94+
val url = requireNotNull(capturedUrl) { "expected URL to be captured" }
95+
assertTrue(url.contains("measurement_id=G-XXX"))
96+
assertTrue(url.contains("api_secret=secret"))
9697
}
9798

9899
@Test

backend/src/test/kotlin/flagent/performance/PerformanceTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class PerformanceTest {
102102
flagKey = null,
103103
entityID = entity["entityID"] as String,
104104
entityType = null,
105-
entityContext = entity["entityContext"] as Map<String, Any>,
105+
entityContext = @Suppress("UNCHECKED_CAST") (entity["entityContext"] as Map<String, Any>),
106106
enableDebug = false
107107
)
108108
}

backend/src/test/kotlin/flagent/repository/impl/FlagRepositoryTest.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ class FlagRepositoryTest {
199199
assertEquals(5L, created.environmentId)
200200
val found = repository.findById(created.id)
201201
assertNotNull(found)
202-
assertEquals(5L, found?.environmentId)
202+
assertEquals(5L, found.environmentId)
203203
}
204204

205205
@Test
@@ -215,7 +215,7 @@ class FlagRepositoryTest {
215215
assertEquals(20L, updated.environmentId)
216216
val found = repository.findById(created.id)
217217
assertNotNull(found)
218-
assertEquals(20L, found?.environmentId)
218+
assertEquals(20L, found.environmentId)
219219
}
220220

221221
@Test
@@ -250,7 +250,7 @@ class FlagRepositoryTest {
250250
val restored = repository.restore(created.id)
251251

252252
assertNotNull(restored)
253-
assertEquals(created.id, restored?.id)
253+
assertEquals(created.id, restored.id)
254254

255255
val found = repository.findById(created.id)
256256
assertNotNull(found)
@@ -421,8 +421,8 @@ class FlagRepositoryTest {
421421
assertNull(repository.findById(created.id))
422422
val included = repository.findByIdIncludeDeleted(created.id)
423423
assertNotNull(included)
424-
assertEquals(created.id, included?.id)
425-
assertEquals("archived_flag", included?.key)
424+
assertEquals(created.id, included.id)
425+
assertEquals("archived_flag", included.key)
426426
}
427427

428428
@Test

backend/src/test/kotlin/flagent/service/ExportServiceTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ class ExportServiceTest {
3535

3636
@BeforeTest
3737
fun setup() {
38-
// Initialize in-memory database for testing
39-
FlagentDatabase.init()
38+
// Use in-memory SQLite so tests don't depend on CI Postgres; export logic is driver-agnostic
39+
FlagentDatabase.initForTests("jdbc:sqlite::memory:", "org.sqlite.JDBC")
4040

4141
// Create repositories
4242
flagRepository = FlagRepository()

0 commit comments

Comments
 (0)