properties exception

Author: Maxcastel

src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php

@@ -483,12 +483,19 @@ private function createParametersFromAttributes(Operation $operation): Parameter
             foreach ($reflectionProperty->getAttributes(Parameter::class, \ReflectionAttribute::IS_INSTANCEOF) as $attribute) {
                 $parameter = $attribute->newInstance();
 
-                $key = $parameter->getKey() ?? $reflectionProperty->getName();
-
-                if (null === $parameter->getProperty()) {
-                    $parameter = $parameter->withProperty($reflectionProperty->getName());
-                } elseif ($parameter->getProperty() !== $reflectionProperty->getName()) {
-                    throw new RuntimeException(\sprintf('Parameter attribute on property "%s" must target itself or have no explicit property. Got "property: \'%s\'" instead.', $reflectionProperty->getName(), $parameter->getProperty()));
+                $propertyName = $reflectionProperty->getName();
+                $key = $parameter->getKey() ?? $propertyName;
+
+                if (null === $parameterPropertyName = $parameter->getProperty()) {
+                    $parameter = $parameter->withProperty($propertyName);
+                } elseif ($parameterPropertyName !== $propertyName) {
+                    throw new RuntimeException(\sprintf('Parameter attribute on property "%s" must target itself or have no explicit property. Got "property: \'%s\'" instead.', $propertyName, $parameterPropertyName));
+                } 
+
+                if (null === $parameterProperties = $parameter->getProperties()) {
+                    $parameter = $parameter->withProperties([$propertyName]);
+                } elseif (!\in_array($propertyName, $parameterProperties, true)) {
+                    throw new RuntimeException(\sprintf('Parameter attribute on property "%s" must target itself or have no explicit properties. Got "properties: [%s]" instead.', $propertyName, implode(', ', $parameterProperties)));
                 }
 
                 $parameters->add($key, $parameter);

src/Metadata/Tests/Resource/Factory/ParameterResourceMetadataCollectionFactoryTest.php

@@ -347,7 +347,33 @@ public function testQueryParameterFromPropertyAttributeThrowsExceptionWhenProper
             $filterLocator
         );
 
-        $parameterFactory->create(ParameterOnPropertiesMismatchException::class);
+        $parameterFactory->create(ParameterOnPropertiesMismatchPropertyException::class);
+    }
+
+    public function testQueryParameterFromPropertyAttributeThrowsExceptionWhenPropertiesMismatch(): void
+    {
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Parameter attribute on property "name" must target itself or have no explicit properties. Got "properties: [description]" instead.');
+
+        $nameCollection = $this->createStub(PropertyNameCollectionFactoryInterface::class);
+        $nameCollection->method('create')->willReturn(new PropertyNameCollection(['id', 'name', 'description']));
+
+        $propertyMetadata = $this->createStub(PropertyMetadataFactoryInterface::class);
+        $propertyMetadata->method('create')->willReturn(
+            new ApiProperty(readable: true),
+        );
+
+        $filterLocator = $this->createStub(ContainerInterface::class);
+        $filterLocator->method('has')->willReturn(false);
+
+        $parameterFactory = new ParameterResourceMetadataCollectionFactory(
+            $nameCollection,
+            $propertyMetadata,
+            new AttributesResourceMetadataCollectionFactory(),
+            $filterLocator
+        );
+
+        $parameterFactory->create(ParameterOnPropertiesMismatchPropertiesException::class);
     }
 
     public function testNestedPropertyWithNameConverter(): void
@@ -617,10 +643,21 @@ class ParameterOnProperties
 }
 
 #[ApiResource]
-class ParameterOnPropertiesMismatchException
+class ParameterOnPropertiesMismatchPropertyException
 {
     #[QueryParameter(key: 'search', property: 'description')]
     public string $name = '';
 
     public string $description = '';
 }
+
+#[ApiResource]
+class ParameterOnPropertiesMismatchPropertiesException
+{
+    #[QueryParameter(key: 'search', properties: ['description'])]
+    public string $name = '';
+
+    public string $description = '';
+}
+
+