test

Author: soyuka

src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php

@@ -132,13 +132,15 @@ private function getProperties(string $resourceClass, ?Parameter $parameter = nu
                 $relationSegments = [];
                 $convertedRelationSegments = [];
                 $relationClasses = [];
+                $traversalSuccessful = true;
 
                 foreach ($parts as $i => $part) {
                     $isLastPart = ($i === \count($parts) - 1);
 
                     try {
                         $propertyMetadata = $this->propertyMetadataFactory->create($currentClass, $part);
                     } catch (\Exception $e) {
+                        $traversalSuccessful = false;
                         break;
                     }
 
@@ -174,17 +176,17 @@ private function getProperties(string $resourceClass, ?Parameter $parameter = nu
                         }
 
                         if (!$nextClass) {
+                            $traversalSuccessful = false;
                             break;
                         }
 
                         $currentClass = $nextClass;
                     }
 
                     if ($propertyMetadata->isReadable()) {
-                        $propertyNames[] = $property;
-
                         // For leaf property, apply name conversion and store full metadata
                         if ($isLastPart) {
+                            $propertyNames[] = $property;
                             $leafProperty = $this->nameConverter?->normalize($part) ?? $part;
 
                             $properties[$property] = $propertyMetadata->withExtraProperties([
@@ -207,6 +209,12 @@ private function getProperties(string $resourceClass, ?Parameter $parameter = nu
                     continue;
                 }
 
+                // If traversal wasn't fully successful but the property was explicitly listed
+                // (e.g., in parameter's properties array for placeholder expansion), still include it
+                if (!$traversalSuccessful && !\in_array($property, $propertyNames, true)) {
+                    $propertyNames[] = $property;
+                }
+
                 // Skip the simple property processing below for nested properties
                 continue;
             }

src/Metadata/Tests/Resource/Factory/ParameterResourceMetadataCollectionFactoryTest.php

@@ -38,13 +38,11 @@ public function testParameterFactory(): void
         $nameCollection = $this->createStub(PropertyNameCollectionFactoryInterface::class);
         $nameCollection->method('create')->willReturn(new PropertyNameCollection(['id', 'hydra', 'everywhere']));
         $propertyMetadata = $this->createStub(PropertyMetadataFactoryInterface::class);
-        $propertyMetadata->method('create')->willReturnOnConsecutiveCalls(
-            new ApiProperty(identifier: true),
-            new ApiProperty(readable: true),
-            new ApiProperty(readable: true),
-            new ApiProperty(identifier: true),
-            new ApiProperty(readable: true),
-            new ApiProperty(readable: true)
+        $propertyMetadata->method('create')->willReturnCallback(
+            static fn (string $class, string $property) => match ($property) {
+                'id' => new ApiProperty(identifier: true),
+                default => new ApiProperty(readable: true),
+            }
         );
         $filterLocator = $this->createStub(ContainerInterface::class);
         $filterLocator->method('has')->willReturn(true);
@@ -185,13 +183,11 @@ public function testParameterFactoryNoFilter(): void
         $nameCollection = $this->createStub(PropertyNameCollectionFactoryInterface::class);
         $nameCollection->method('create')->willReturn(new PropertyNameCollection(['id', 'hydra', 'everywhere']));
         $propertyMetadata = $this->createStub(PropertyMetadataFactoryInterface::class);
-        $propertyMetadata->method('create')->willReturnOnConsecutiveCalls(
-            new ApiProperty(identifier: true),
-            new ApiProperty(readable: true),
-            new ApiProperty(readable: true),
-            new ApiProperty(identifier: true),
-            new ApiProperty(readable: true),
-            new ApiProperty(readable: true)
+        $propertyMetadata->method('create')->willReturnCallback(
+            static fn (string $class, string $property) => match ($property) {
+                'id' => new ApiProperty(identifier: true),
+                default => new ApiProperty(readable: true),
+            }
         );
         $filterLocator = $this->createStub(ContainerInterface::class);
         $filterLocator->method('has')->willReturn(false);