Remove favorite connection

Author: Maxteabag

sqlit/core/keymap.py

@@ -310,7 +310,6 @@ def _build_action_keys(self) -> list[ActionKeyDef]:
             ActionKeyDef("d", "delete_connection", "tree"),
             ActionKeyDef("delete", "delete_connection", "tree", primary=False),
             ActionKeyDef("D", "duplicate_connection", "tree"),
-            ActionKeyDef("asterisk", "toggle_connection_favorite", "tree"),
             ActionKeyDef("m", "move_connection_to_folder", "tree"),
             ActionKeyDef("x", "disconnect", "tree"),
             ActionKeyDef("z", "collapse_tree", "tree"),

sqlit/domains/connections/domain/config.py

@@ -126,7 +126,6 @@ class ConnectionConfig:
     tunnel: TunnelConfig | None = None
     source: str | None = None
     connection_url: str | None = None
-    favorite: bool = False
     folder_path: str = ""
     extra_options: dict[str, str] = field(default_factory=dict)
     options: dict[str, Any] = field(default_factory=dict)
@@ -218,7 +217,6 @@ def from_dict(cls, data: Mapping[str, Any]) -> ConnectionConfig:
             "db_type",
             "source",
             "connection_url",
-            "favorite",
             "folder_path",
             "extra_options",
         }
@@ -230,10 +228,6 @@ def from_dict(cls, data: Mapping[str, Any]) -> ConnectionConfig:
             else:
                 payload.pop(key)
 
-        raw_favorite = payload.get("favorite", False)
-        favorite = bool(raw_favorite)
-        if isinstance(raw_favorite, str):
-            favorite = raw_favorite.strip().lower() in {"1", "true", "yes", "y", "on"}
         folder_path = normalize_folder_path(payload.get("folder_path", ""))
 
         return cls(
@@ -243,7 +237,6 @@ def from_dict(cls, data: Mapping[str, Any]) -> ConnectionConfig:
             tunnel=tunnel,
             source=payload.get("source"),
             connection_url=payload.get("connection_url"),
-            favorite=favorite,
             folder_path=folder_path,
             extra_options=dict(payload.get("extra_options") or {}),
             options=options,
@@ -311,7 +304,6 @@ def to_dict(self, *, include_passwords: bool = True) -> dict[str, Any]:
             "db_type": self.db_type,
             "source": self.source,
             "connection_url": self.connection_url,
-            "favorite": self.favorite,
             "folder_path": self.folder_path,
             "extra_options": dict(self.extra_options),
             "options": dict(self.options),
@@ -538,7 +530,7 @@ def ssh_key_path(self, value: str) -> None:
 
 
 SOURCE_EMOJIS: dict[str, str] = {
-    "docker": "🐳 ",
+    "docker": "",
     "azure": "",
 }
 

sqlit/domains/connections/ui/mixins/connection.py

@@ -797,79 +797,6 @@ def _update_visual_selection(self: ConnectionMixinHost) -> None:
 
         self._update_footer_bindings()
 
-    def action_toggle_connection_favorite(self: ConnectionMixinHost) -> None:
-        from sqlit.domains.connections.app.credentials import CredentialsPersistError
-        from sqlit.shared.ui.screens.error import ErrorScreen
-
-        selected = self._get_selected_connection_configs()
-        if selected:
-            previous = {c.name: c.favorite for c in selected}
-            set_favorite = not all(c.favorite for c in selected)
-            for conn in selected:
-                conn.favorite = set_favorite
-            credentials_error: CredentialsPersistError | None = None
-
-            try:
-                self.services.connection_store.save_all(self.connections)
-            except CredentialsPersistError as exc:
-                credentials_error = exc
-            except Exception as exc:
-                for conn in selected:
-                    conn.favorite = previous.get(conn.name, conn.favorite)
-                self.notify(f"Failed to update favorite: {exc}", severity="error")
-                return
-
-            if not self.services.connection_store.is_persistent:
-                self.notify("Connections are not persisted in this session", severity="warning")
-
-            self._get_selected_connection_names().clear()
-            setattr(self, "_tree_visual_mode_anchor", None)
-            self._refresh_connection_tree()
-            action_label = "starred" if set_favorite else "unstarred"
-            if len(selected) == 1:
-                self.notify(f"Connection {action_label}")
-            else:
-                self.notify(f"{len(selected)} connections {action_label}")
-            if credentials_error:
-                self.push_screen(ErrorScreen("Keyring Error", str(credentials_error)))
-            return
-
-        node = self.object_tree.cursor_node
-        if not node:
-            return
-
-        config = self._get_connection_config_from_node(node)
-        if not config:
-            return
-
-        if not any(c.name == config.name for c in self.connections):
-            self.notify("Only saved connections can be starred", severity="warning")
-            return
-
-        previous = config.favorite
-        config.favorite = not previous
-        credentials_error: CredentialsPersistError | None = None
-
-        try:
-            self.services.connection_store.save_all(self.connections)
-        except CredentialsPersistError as exc:
-            credentials_error = exc
-        except Exception as exc:
-            config.favorite = previous
-            self.notify(f"Failed to update favorite: {exc}", severity="error")
-            return
-
-        if not self.services.connection_store.is_persistent:
-            self.notify("Connections are not persisted in this session", severity="warning")
-
-        self._refresh_connection_tree()
-        if config.favorite:
-            self.notify("Connection starred")
-        else:
-            self.notify("Connection unstarred")
-        if credentials_error:
-            self.push_screen(ErrorScreen("Keyring Error", str(credentials_error)))
-
     def action_move_connection_to_folder(self: ConnectionMixinHost) -> None:
         from sqlit.domains.connections.app.credentials import CredentialsPersistError
         from sqlit.domains.connections.domain.config import normalize_folder_path

sqlit/domains/connections/ui/screens/connection.py

@@ -665,7 +665,6 @@ def _get_config(self) -> ConnectionConfig | None:
         config_data["endpoint"] = endpoint
         config_data["tunnel"] = tunnel
         if self.editing and self.config is not None:
-            config_data["favorite"] = getattr(self.config, "favorite", False)
             config_data["folder_path"] = getattr(self.config, "folder_path", "")
 
         config = ConnectionConfig.from_dict(config_data)

sqlit/domains/connections/ui/screens/connection_picker/screen.py

@@ -51,7 +51,6 @@ class ConnectionPickerScreen(ModalScreen):
     BINDINGS = [
         Binding("escape", "cancel_or_close_filter", "Cancel"),
         Binding("enter", "select", "Select"),
-        Binding("asterisk", "toggle_star", "Star", show=False),
         Binding("s", "save", "Save", show=False),
         Binding("n", "new_connection", "New", show=False),
         Binding("f", "refresh", "Refresh", show=False),
@@ -539,45 +538,6 @@ def action_save(self) -> None:
                 self._save_connection_and_refresh(config, option_id)
             return
 
-    def action_toggle_star(self) -> None:
-        if self._current_tab == TAB_CLOUD:
-            return
-
-        option = self._get_highlighted_option()
-        if not option or option.disabled:
-            return
-
-        option_id = str(option.id) if option.id else ""
-        if not option_id or is_docker_option_id(option_id):
-            return
-
-        config = find_connection_by_name(self.connections, option_id)
-        if not config:
-            return
-
-        from sqlit.domains.connections.app.credentials import CredentialsPersistError
-
-        was_favorite = config.favorite
-        config.favorite = not was_favorite
-        try:
-            self._app().services.connection_store.save_all(self.connections)
-        except CredentialsPersistError as exc:
-            self.notify(str(exc), severity="error")
-        except Exception as exc:
-            config.favorite = was_favorite
-            self.notify(f"Failed to update favorite: {exc}", severity="error")
-            self._update_list()
-            return
-
-        if not self._app().services.connection_store.is_persistent:
-            self.notify("Connections are not persisted in this session", severity="warning")
-
-        if config.favorite:
-            self.notify("Connection starred")
-        else:
-            self.notify("Connection unstarred")
-        self._update_list()
-
     def _save_cloud_selection(self) -> None:
         tree_node = self._get_highlighted_tree_node()
         if not tree_node or not tree_node.data:

sqlit/domains/connections/ui/screens/connection_picker/shortcuts.py

@@ -22,7 +22,6 @@
     find_container_by_id,
     is_container_saved,
 )
-from sqlit.domains.connections.ui.screens.connection_picker.tabs.connections import find_connection_by_name
 
 
 def build_picker_shortcuts(
@@ -69,7 +68,6 @@ def _build_list_shortcuts(
     show_save = False
     is_connectable = False
     provider_shortcuts: list[tuple[str, str]] = []
-    star_action: tuple[str, str] | None = None
 
     if option:
         option_id = str(option.id) if option.id else ""
@@ -97,24 +95,14 @@ def _build_list_shortcuts(
         if current_tab == TAB_CONNECTIONS and option_id:
             is_connectable = True
 
-        if option_id and not option_id.startswith(DOCKER_PREFIX):
-            conn = find_connection_by_name(connections, option_id)
-            if conn:
-                star_label = "Unstar" if conn.favorite else "Star"
-                star_action = (star_label, "*")
-
     shortcuts = provider_shortcuts
     if not shortcuts:
         action_label = "Connect" if is_connectable else "Select"
         shortcuts = [(action_label, "enter")]
         if show_save:
             shortcuts.append(("Save", "s"))
-        if star_action:
-            shortcuts.append(star_action)
         if current_tab == TAB_CONNECTIONS:
             shortcuts.append(("New", "n"))
-    elif star_action:
-        shortcuts.append(star_action)
 
     if current_tab in (TAB_DOCKER, TAB_CLOUD):
         shortcuts.append(("Refresh", "f"))

sqlit/domains/connections/ui/screens/connection_picker/tabs/connections.py

@@ -15,28 +15,20 @@ def build_connections_options(
 ) -> list[Option]:
     options: list[Option] = []
 
-    favorite_options: list[Option] = []
     saved_options: list[Option] = []
     for conn in connections:
         matches, indices = fuzzy_match(pattern, conn.name)
         if matches or not pattern:
             display = highlight_matches(conn.name, indices)
             db_type = conn.db_type.upper() if conn.db_type else "DB"
             info = get_connection_display_info(conn)
-            source_prefix = ""
-            if conn.source == "docker":
-                source_prefix = "docker "
-            star = "[yellow]*[/] " if conn.favorite else "  "
-            option = Option(f"{star}{source_prefix}{display} [{db_type}] [dim]({info})[/]", id=conn.name)
-            if conn.favorite:
-                favorite_options.append(option)
-            else:
-                saved_options.append(option)
+            option = Option(f"{display} [{db_type}] [dim]({info})[/]", id=conn.name)
+            saved_options.append(option)
 
     options.append(Option("[bold]Saved[/]", id="_header_saved", disabled=True))
 
-    if favorite_options or saved_options:
-        options.extend(favorite_options + saved_options)
+    if saved_options:
+        options.extend(saved_options)
     else:
         options.append(Option("[dim](no saved connections)[/]", id="_empty_saved", disabled=True))
 

sqlit/domains/connections/ui/screens/connection_picker/tabs/docker.py

@@ -90,7 +90,6 @@ def build_docker_options(
 ) -> list[Option]:
     options: list[Option] = []
 
-    favorite_options: list[Option] = []
     saved_options: list[Option] = []
     for conn in connections:
         if conn.source != "docker":
@@ -100,12 +99,8 @@ def build_docker_options(
             display = highlight_matches(conn.name, indices)
             db_type = conn.db_type.upper() if conn.db_type else "DB"
             info = get_connection_display_info(conn)
-            star = "[yellow]*[/] " if conn.favorite else "  "
-            option = Option(f"{star}docker {display} [{db_type}] [dim]({info})[/]", id=conn.name)
-            if conn.favorite:
-                favorite_options.append(option)
-            else:
-                saved_options.append(option)
+            option = Option(f"{display} [{db_type}] [dim]({info})[/]", id=conn.name)
+            saved_options.append(option)
 
     running_options: list[Option] = []
     exited_options: list[Option] = []
@@ -123,30 +118,30 @@ def build_docker_options(
                 if container.connectable:
                     running_options.append(
                         Option(
-                            f"docker {display} [{db_label}] [dim](localhost{port_info})[/]",
+                            f"{display} [{db_label}] [dim](localhost{port_info})[/]",
                             id=f"{DOCKER_PREFIX}{container.container_id}",
                         )
                     )
                 else:
                     running_options.append(
                         Option(
-                            f"docker {display} [{db_label}] [dim](not exposed)[/]",
+                            f"{display} [{db_label}] [dim](not exposed)[/]",
                             id=f"{DOCKER_PREFIX}{container.container_id}",
                             disabled=True,
                         )
                     )
             else:
                 exited_options.append(
                     Option(
-                        f"[dim]docker {display} [{db_label}] (Stopped)[/]",
+                        f"[dim]{display} [{db_label}] (Stopped)[/]",
                         id=f"{DOCKER_PREFIX}{container.container_id}",
                     )
                 )
 
     options.append(Option("[bold]Saved[/]", id="_header_docker_saved", disabled=True))
 
-    if favorite_options or saved_options:
-        options.extend(favorite_options + saved_options)
+    if saved_options:
+        options.extend(saved_options)
     else:
         options.append(Option("[dim](no saved Docker connections)[/]", id="_empty_docker_saved", disabled=True))
 

sqlit/domains/explorer/state/tree_multi_select.py

@@ -17,11 +17,6 @@ def _setup_actions(self) -> None:
             label="Clear",
             help="Clear selection",
         )
-        self.allows(
-            "toggle_connection_favorite",
-            label="Star",
-            help="Star selected connections",
-        )
         self.allows(
             "move_connection_to_folder",
             label="Move",
@@ -45,14 +40,6 @@ def get_display_bindings(self, app: InputContext) -> tuple[list[DisplayBinding],
             )
         )
         seen.add("clear_connection_selection")
-        left.append(
-            DisplayBinding(
-                key=resolve_display_key("toggle_connection_favorite") or "*",
-                label="Star",
-                action="toggle_connection_favorite",
-            )
-        )
-        seen.add("toggle_connection_favorite")
         left.append(
             DisplayBinding(
                 key=resolve_display_key("move_connection_to_folder") or "m",

sqlit/domains/explorer/state/tree_on_connection.py

@@ -37,11 +37,6 @@ def is_connected_to_this(app: InputContext) -> bool:
         self.allows("edit_connection", label="Edit", help="Edit connection")
         self.allows("delete_connection", label="Delete", help="Delete connection")
         self.allows("duplicate_connection", label="Duplicate", help="Duplicate connection")
-        self.allows(
-            "toggle_connection_favorite",
-            label="Star",
-            help="Toggle favorite connection",
-        )
         self.allows(
             "move_connection_to_folder",
             label="Move",
@@ -98,14 +93,6 @@ def get_display_bindings(self, app: InputContext) -> tuple[list[DisplayBinding],
             )
         )
         seen.add("duplicate_connection")
-        left.append(
-            DisplayBinding(
-                key=resolve_display_key("toggle_connection_favorite") or "*",
-                label="Star",
-                action="toggle_connection_favorite",
-            )
-        )
-        seen.add("toggle_connection_favorite")
         left.append(
             DisplayBinding(
                 key=resolve_display_key("move_connection_to_folder") or "m",