fix: use standard password field for MotherDuck token

- Use standard password field (stored in keyring) instead of custom token field
- Fix file-based vs tcp-based endpoint handling
- Access token is now stored securely via credentials service

Author: Maxteabag

sqlit/domains/connections/providers/motherduck/adapter.py

@@ -31,15 +31,15 @@ def connect(self, config: ConnectionConfig) -> Any:
             package_name=self.install_package,
         )
 
-        # Get database from file_path
-        database = ""
-        if config.file_endpoint and config.file_endpoint.path:
-            database = config.file_endpoint.path.lstrip("/")
-
-        # Get token from extra_options (URL) or options (UI)
-        token = config.extra_options.get("motherduck_token", "")
-        if not token:
-            token = config.get_option("motherduck_token", "")
+        # Get database from options or tcp_endpoint
+        database = config.get_option("database", "")
+        if not database and config.tcp_endpoint:
+            database = config.tcp_endpoint.database
+
+        # Get token from tcp_endpoint.password (stored in keyring)
+        token = ""
+        if config.tcp_endpoint:
+            token = config.tcp_endpoint.password or ""
 
         if not database:
             raise ValueError("MotherDuck connections require a database name.")

sqlit/domains/connections/providers/motherduck/provider.py

@@ -11,7 +11,7 @@ def _display_info(config) -> str:
     database = config.get_option("database", "") or config.database or ""
     if database:
         return f"md:{database}"
-    return "md: (default)"
+    return "MotherDuck"
 
 
 def _provider_factory(spec: ProviderSpec) -> DatabaseProvider:
@@ -25,7 +25,7 @@ def _provider_factory(spec: ProviderSpec) -> DatabaseProvider:
     display_name="MotherDuck",
     schema_path=("sqlit.domains.connections.providers.motherduck.schema", "SCHEMA"),
     supports_ssh=False,
-    is_file_based=True,  # Use file-based URL parsing (motherduck:///database)
+    is_file_based=False,
     has_advanced_auth=False,
     default_port="",
     requires_auth=True,

sqlit/domains/connections/providers/motherduck/schema.py

@@ -11,19 +11,19 @@
     display_name="MotherDuck",
     fields=(
         SchemaField(
-            name="file_path",
+            name="database",
             label="Database",
             placeholder="my_database",
             required=True,
         ),
         SchemaField(
-            name="motherduck_token",
+            name="password",
             label="Access Token",
             field_type=FieldType.PASSWORD,
             required=True,
         ),
     ),
     supports_ssh=False,
-    is_file_based=True,
+    is_file_based=False,  # Not file-based, uses database + token
     requires_auth=True,
 )

tests/unit/test_motherduck_adapter.py

@@ -2,8 +2,6 @@
 
 from __future__ import annotations
 
-from sqlit.domains.connections.domain.config import ConnectionConfig, FileEndpoint
-
 
 def test_motherduck_provider_registered():
     """Test that MotherDuck provider is properly registered."""
@@ -19,7 +17,7 @@ def test_motherduck_provider_metadata():
 
     provider = get_provider("motherduck")
     assert provider.metadata.display_name == "MotherDuck"
-    assert provider.metadata.is_file_based is True
+    assert provider.metadata.is_file_based is False
     assert provider.metadata.supports_ssh is False
     assert provider.metadata.requires_auth is True
     assert "md" in provider.metadata.url_schemes
@@ -33,23 +31,14 @@ def test_motherduck_database_type_enum():
     assert DatabaseType.MOTHERDUCK.value == "motherduck"
 
 
-def test_motherduck_url_parsing():
-    """Test MotherDuck URL parsing."""
-    from sqlit.domains.connections.app.url_parser import parse_connection_url
-
-    config = parse_connection_url("motherduck:///my_database?motherduck_token=abc123")
-
-    assert config.db_type == "motherduck"
-    assert config.file_path == "/my_database"
-    assert config.extra_options.get("motherduck_token") == "abc123"
-
-
-def test_motherduck_md_scheme_url_parsing():
-    """Test MotherDuck md:// URL parsing."""
-    from sqlit.domains.connections.app.url_parser import parse_connection_url
+def test_motherduck_schema_uses_password_field():
+    """Test MotherDuck schema uses standard password field for token."""
+    from sqlit.domains.connections.providers.motherduck.schema import SCHEMA
 
-    config = parse_connection_url("md:///prod_db?motherduck_token=xyz789")
+    field_names = [f.name for f in SCHEMA.fields]
+    assert "database" in field_names
+    assert "password" in field_names  # Uses standard password field for token
 
-    assert config.db_type == "motherduck"
-    assert config.file_path == "/prod_db"
-    assert config.extra_options.get("motherduck_token") == "xyz789"
+    # Password field should be labeled as "Access Token"
+    password_field = next(f for f in SCHEMA.fields if f.name == "password")
+    assert password_field.label == "Access Token"